Source/platform/graphics/filters/PointLightSource.cpp - Issue 951523002: Remove PaintingData from LightSource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/filters/PointLightSource.cpp

Issue 951523002: Remove PaintingData from LightSource (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/graphics/filters/PointLightSource.cpp

diff --git a/Source/platform/graphics/filters/PointLightSource.cpp b/Source/platform/graphics/filters/PointLightSource.cpp

index 6d41dde549b77d84ab24fd565e422ecd3a0910af..5fcb922c120d762e85a51bb4b1a918a661af3fed 100644

--- a/Source/platform/graphics/filters/PointLightSource.cpp

+++ b/Source/platform/graphics/filters/PointLightSource.cpp

@@ -35,18 +35,6 @@

namespace blink {

-void PointLightSource::initPaintingData(PaintingData&) const

-void PointLightSource::updatePaintingData(PaintingData& paintingData, int x, int y, float z) const

- paintingData.lightVector.setX(m_position.x() - x);

- paintingData.lightVector.setY(m_position.y() - y);

- paintingData.lightVector.setZ(m_position.z() - z);

- paintingData.lightVectorLength = paintingData.lightVector.length();

bool PointLightSource::setPosition(const FloatPoint3D& position)

{

if (m_position == position)