Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 939623005: Pass Rendertarget into context (Closed)

Created:
5 years, 10 months ago by joshua.litt
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Pass Rendertarget into context. Adding Jim for text context stuff, and Steven for image blur stuff. BUG=skia: Committed: https://skia.googlesource.com/skia/+/25d9c154087d2132a51d1ca74a104726f60ef380

Patch Set 1 #

Patch Set 2 : pass down rendertarget #

Total comments: 2

Patch Set 3 : nits #

Patch Set 4 : sampleapp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -310 lines) Patch
M gm/texdata.cpp View 1 3 chunks +2 lines, -4 lines 0 comments Download
M include/core/SkMaskFilter.h View 3 chunks +3 lines, -0 lines 0 comments Download
M include/gpu/GrContext.h View 1 14 chunks +29 lines, -58 lines 0 comments Download
M include/gpu/SkGr.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 8 chunks +8 lines, -5 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 2 chunks +1 line, -3 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 1 13 chunks +22 lines, -24 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 5 chunks +21 lines, -20 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/GrBitmapTextContext.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 1 7 chunks +11 lines, -8 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 23 chunks +45 lines, -35 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 7 chunks +13 lines, -11 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 1 7 chunks +12 lines, -9 lines 0 comments Download
M src/gpu/GrTextContext.h View 1 1 chunk +17 lines, -14 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 1 5 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 33 chunks +85 lines, -66 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 2 7 chunks +12 lines, -17 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
joshualitt
5 years, 10 months ago (2015-02-18 19:08:53 UTC) #3
Stephen White
src/effects LGTM
5 years, 10 months ago (2015-02-18 19:23:52 UTC) #4
bsalomon
lgtm, some minor comments. https://codereview.chromium.org/939623005/diff/20001/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.chromium.org/939623005/diff/20001/src/gpu/GrContext.cpp#newcode1432 src/gpu/GrContext.cpp:1432: ASSERT_OWNED_RESOURCE(rt); Maybe assert(rt) too? ASSERT_OWNED_RESOURCE ...
5 years, 10 months ago (2015-02-18 19:30:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939623005/40001
5 years, 10 months ago (2015-02-18 19:41:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/2133) Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 10 months ago (2015-02-18 19:44:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939623005/50025
5 years, 10 months ago (2015-02-18 20:23:40 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 20:29:56 UTC) #13
Message was sent while issue was closed. 
Committed patchset #4 (id:50025) as
https://skia.googlesource.com/skia/+/25d9c154087d2132a51d1ca74a104726f60ef380

Powered by Google App Engine
This is Rietveld 408576698