Dynamically create stencil buffer when needed.

Dynamically create stencil buffer when needed.

Committed: https://skia.googlesource.com/skia/+/6bc1b5fab8554a9cb643277b4867965dd4535cd6

[bsalomon, 2015-02-20 19:00:13]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2015-02-20 19:57:21]

https://codereview.chromium.org/938383004/diff/60001/src/gpu/GrRenderTargetPr...
File src/gpu/GrRenderTargetPriv.h (right):

https://codereview.chromium.org/938383004/diff/60001/src/gpu/GrRenderTargetPr...
src/gpu/GrRenderTargetPriv.h:32: GrRenderTargetPriv(GrRenderTarget*
renderTarget) : fRenderTarget(renderTarget) {}
Do we need the ctor that takes a const GrRenderTargetPriv? It seems a bit odd.

https://codereview.chromium.org/938383004/diff/60001/src/gpu/GrSurfacePriv.h
File src/gpu/GrSurfacePriv.h (right):

https://codereview.chromium.org/938383004/diff/60001/src/gpu/GrSurfacePriv.h#...
src/gpu/GrSurfacePriv.h:37: GrSurfacePriv(GrSurface* surface) :
fSurface(surface) {}
Same here I guess.

[robertphillips, 2015-02-20 20:00:58]

https://codereview.chromium.org/938383004/diff/60001/src/gpu/GrGpu.cpp
File src/gpu/GrGpu.cpp (right):

https://codereview.chromium.org/938383004/diff/60001/src/gpu/GrGpu.cpp#newcode99
src/gpu/GrGpu.cpp:99: if (this->createStencilBufferForRenderTarget(rt, width,
height)) {
This comment seems important.

[bsalomon, 2015-02-20 20:02:56]

https://codereview.chromium.org/938383004/diff/60001/src/gpu/GrGpu.cpp
File src/gpu/GrGpu.cpp (right):

https://codereview.chromium.org/938383004/diff/60001/src/gpu/GrGpu.cpp#newcode99
src/gpu/GrGpu.cpp:99: if (this->createStencilBufferForRenderTarget(rt, width,
height)) {
On 2015/02/20 20:00:58, robertphillips wrote:
> This comment seems important.

Yikes! Yes.

[bsalomon, 2015-02-20 20:10:39]

https://codereview.chromium.org/938383004/diff/60001/src/gpu/GrRenderTargetPr...
File src/gpu/GrRenderTargetPriv.h (right):

https://codereview.chromium.org/938383004/diff/60001/src/gpu/GrRenderTargetPr...
src/gpu/GrRenderTargetPriv.h:32: GrRenderTargetPriv(GrRenderTarget*
renderTarget) : fRenderTarget(renderTarget) {}
On 2015/02/20 19:57:21, robertphillips wrote:
> Do we need the ctor that takes a const GrRenderTargetPriv? It seems a bit odd.

Done.

https://codereview.chromium.org/938383004/diff/60001/src/gpu/GrSurfacePriv.h
File src/gpu/GrSurfacePriv.h (right):

https://codereview.chromium.org/938383004/diff/60001/src/gpu/GrSurfacePriv.h#...
src/gpu/GrSurfacePriv.h:37: GrSurfacePriv(GrSurface* surface) :
fSurface(surface) {}
On 2015/02/20 19:57:21, robertphillips wrote:
> Same here I guess.

Done.

[bsalomon, 2015-02-23 14:43:26]

On 2015/02/20 20:02:56, bsalomon wrote:
> https://codereview.chromium.org/938383004/diff/60001/src/gpu/GrGpu.cpp
> File src/gpu/GrGpu.cpp (right):
> 
>
https://codereview.chromium.org/938383004/diff/60001/src/gpu/GrGpu.cpp#newcode99
> src/gpu/GrGpu.cpp:99: if (this->createStencilBufferForRenderTarget(rt, width,
> height)) {
> On 2015/02/20 20:00:58, robertphillips wrote:
> > This comment seems important.
> 
> Yikes! Yes.

This is addressed in this patch: https://codereview.chromium.org/941383003/

[robertphillips, 2015-02-23 14:51:03]

lgtm

[bsalomon, 2015-02-23 16:53:14]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-02-23 16:53:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/938383004/100001

[commit-bot: I haz the power, 2015-02-23 17:06:41]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/6bc1b5fab8554a9cb643277b4867965dd4535cd6