Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 931003002: Move and rename RenderPart to LayoutPart. (Closed)

Created:
5 years, 10 months ago by mstensho (USE GERRIT)
Modified:
5 years, 10 months ago
CC:
blink-reviews, dshwang, eae+blinkwatch, fs, apavlov+blink_chromium.org, aandrey+blink_chromium.org, rwlbuis, blink-layers+watch_chromium.org, caseq+blink_chromium.org, krit, blink-reviews-events_chromium.org, malch+blink_chromium.org, blink-reviews-html_chromium.org, yurys+blink_chromium.org, Justin Novosad, danakj, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, jchaffraix+rendering, devtools-reviews_chromium.org, pdr+svgwatchlist_chromium.org, kenneth.christiansen, loislo+blink_chromium.org, zoltan1, blink-reviews-paint_chromium.org, sof, jbroman, lushnikov+blink_chromium.org, Dominik Röttsches, eustas+blink_chromium.org, pdr+graphicswatchlist_chromium.org, gyuyoung.kim_webkit.org, Stephen Chennney, blink-reviews-rendering, pdr+renderingwatchlist_chromium.org, kouhei+svg_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, f(malita), sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move and rename RenderPart to LayoutPart. Also make LayoutPart::renderName() pure virtual. Everyone overrides it anyway (except in the unit test, which was easy enough to fix). BUG=450612 TBR=dsinclair@chromium.org,jochen@chromium.org,dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190282

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -700 lines) Patch
M LayoutTests/fast/events/touch/gesture/gesture-scroll-object-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/gesture-scroll-object-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/defer-updateFromElement.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/defer-updateFromElement-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/destroy-reentry.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 4 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/iterators/TextIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Frame.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/Frame.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/FrameView.h View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 13 chunks +14 lines, -14 lines 0 comments Download
M Source/core/frame/RemoteFrame.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/RemoteFrameView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAppletElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAppletElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLEmbedElement.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLFrameElementBase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M Source/core/html/HTMLObjectElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 9 chunks +14 lines, -14 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/HitTestResult.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/Layer.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 2 chunks +1 line, -1 line 0 comments Download
A + Source/core/layout/LayoutPart.h View 5 chunks +8 lines, -10 lines 0 comments Download
A + Source/core/layout/LayoutPart.cpp View 16 chunks +24 lines, -24 lines 0 comments Download
A + Source/core/layout/LayoutPartTest.cpp View 2 chunks +12 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutTreeAsText.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/PaintInfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/compositing/CompositedLayerMapping.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/compositing/CompositingLayerAssigner.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/compositing/LayerCompositor.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/compositing/LayerCompositor.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/PartPainter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/paint/PartPainter.cpp View 2 chunks +27 lines, -27 lines 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderFrame.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderIFrame.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderIFrame.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D Source/core/rendering/RenderPart.h View 1 chunk +0 lines, -83 lines 0 comments Download
D Source/core/rendering/RenderPart.cpp View 1 chunk +0 lines, -318 lines 0 comments Download
D Source/core/rendering/RenderPartTest.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
M Source/core/rendering/RenderScrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXRenderObject.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/graphics/CompositingReasons.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/CompositingReasons.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/FindInPageCoordinates.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/LinkHighlight.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/RemoteFrameClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebNode.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/tests/ScrollingCoordinatorTest.cpp View 3 chunks +13 lines, -13 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
mstensho (USE GERRIT)
5 years, 10 months ago (2015-02-16 22:48:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931003002/1
5 years, 10 months ago (2015-02-16 22:50:31 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 00:09:42 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190282

Powered by Google App Engine
This is Rietveld 408576698