Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 928393003: Remove the concept of document.documentElement (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
esprehn, ojan
CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove the concept of document.documentElement Now documents can have many element children, all created equal. R=esprehn@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a3fb7f068c276413ec90324e01f7991b4ad24ce8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -822 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/SharedStyleFinder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/resolver/StyleAdjuster.cpp View 2 chunks +7 lines, -14 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M sky/engine/core/dom/ContainerNode.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M sky/engine/core/dom/Document.h View 6 chunks +0 lines, -15 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 6 chunks +4 lines, -22 lines 0 comments Download
M sky/engine/core/dom/Document.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/dom/Position.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M sky/engine/core/editing/Editor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/editing/Editor.cpp View 3 chunks +7 lines, -9 lines 0 comments Download
M sky/engine/core/editing/FrameSelection.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/editing/FrameSelection.cpp View 2 chunks +4 lines, -10 lines 0 comments Download
M sky/engine/core/editing/SpellChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
D sky/engine/core/editing/SurroundingText.h View 1 chunk +0 lines, -65 lines 0 comments Download
D sky/engine/core/editing/SurroundingText.cpp View 1 chunk +0 lines, -142 lines 0 comments Download
M sky/engine/core/editing/VisibleSelection.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/editing/VisibleSelection.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
M sky/engine/core/editing/VisibleUnits.cpp View 4 chunks +14 lines, -11 lines 0 comments Download
M sky/engine/core/editing/htmlediting.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/frame/FrameView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +0 lines, -25 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M sky/engine/core/frame/NewEventHandler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/page/EventHandler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 2 chunks +8 lines, -40 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 4 chunks +8 lines, -19 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 5 chunks +6 lines, -29 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 6 chunks +4 lines, -58 lines 0 comments Download
M sky/engine/core/rendering/RenderFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderView.h View 2 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 3 chunks +0 lines, -49 lines 0 comments Download
M sky/engine/public/web/WebDocument.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/public/web/WebFrame.h View 1 chunk +0 lines, -11 lines 0 comments Download
M sky/engine/public/web/WebWidget.h View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/web/WebDocument.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 2 chunks +1 line, -37 lines 0 comments Download
M sky/engine/web/WebRange.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 3 chunks +1 line, -35 lines 0 comments Download
M sky/tests/clipping/background-opaque-clipped-gradients-expected.txt View 1 chunk +6 lines, -7 lines 0 comments Download
M sky/tests/clipping/canvas-rounded-corners-expected.txt View 1 chunk +17 lines, -18 lines 0 comments Download
M sky/tests/layout/continuations-expected.txt View 1 chunk +9 lines, -10 lines 0 comments Download
M sky/tests/layout/ellipsis-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M sky/tests/layout/fixed-width-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download
M sky/tests/lowlevel/camel-case.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/lowlevel/hello-world-expected.txt View 1 chunk +4 lines, -5 lines 0 comments Download
M sky/tests/lowlevel/home-expected.txt View 1 chunk +9 lines, -10 lines 0 comments Download
M sky/tests/lowlevel/iframe-expected.txt View 1 chunk +19 lines, -20 lines 0 comments Download
M sky/tests/lowlevel/img-expected.txt View 1 chunk +3 lines, -4 lines 0 comments Download
M sky/tests/modules/load-event.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/event-sender.sky View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-02-18 00:06:23 UTC) #1
esprehn
lgtm
5 years, 10 months ago (2015-02-18 00:13:55 UTC) #3
abarth-chromium
5 years, 10 months ago (2015-02-18 00:20:12 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a3fb7f068c276413ec90324e01f7991b4ad24ce8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698