sky/engine/core/frame/FrameView.cpp - Issue 928393003: Remove the concept of document.documentElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/frame/FrameView.cpp

Issue 928393003: Remove the concept of document.documentElement (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/frame/FrameView.cpp

diff --git a/sky/engine/core/frame/FrameView.cpp b/sky/engine/core/frame/FrameView.cpp

index 13efb7d915225b756414fa1b42197ed23d780df9..78824ceb4847cc4f5f8e74ab58f4207e776ce1d0 100644

--- a/sky/engine/core/frame/FrameView.cpp

+++ b/sky/engine/core/frame/FrameView.cpp

@@ -621,31 +621,6 @@ float FrameView::inputEventsScaleFactor() const

return pageScale * m_inputEventsScaleFactorForEmulation;

}

-Color FrameView::documentBackgroundColor() const

- // <https://bugs.webkit.org/show_bug.cgi?id=59540> We blend the background color of

- // the document and the body against the base background color of the frame view.

- // Background images are unfortunately impractical to include.

- Color result = baseBackgroundColor();

- if (!frame().document())

- return result;

- Element* htmlElement = frame().document()->documentElement();

- // We take the aggregate of the base background color

- // the <html> background color, and the <body>

- // background color to find the document color. The

- // addition of the base background color is not

- // technically part of the document background, but it

- // otherwise poses problems when the aggregate is not

- // fully opaque.

- if (htmlElement && htmlElement->renderer())

- result = result.blend(htmlElement->renderer()->style()->colorIncludingFallback(CSSPropertyBackgroundColor));

- return result;

void FrameView::paint(GraphicsContext* context, const IntRect& rect)

{

#ifndef NDEBUG

« no previous file with comments | « sky/engine/core/frame/FrameView.h ('k') | sky/engine/core/frame/LocalDOMWindow.h » ('j') | no next file with comments »