sky/engine/core/rendering/RenderFlexibleBox.cpp - Issue 928393003: Remove the concept of document.documentElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderFlexibleBox.cpp

Issue 928393003: Remove the concept of document.documentElement (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderFlexibleBox.cpp

diff --git a/sky/engine/core/rendering/RenderFlexibleBox.cpp b/sky/engine/core/rendering/RenderFlexibleBox.cpp

index d7dfbdba77f1618979c200bfe7648a91e1f05656..e50ed6ea4a64ab4a7b8cb9b91a619eb302eb6e7a 100644

--- a/sky/engine/core/rendering/RenderFlexibleBox.cpp

+++ b/sky/engine/core/rendering/RenderFlexibleBox.cpp

@@ -239,7 +239,7 @@ void RenderFlexibleBox::layout()

if (logicalHeight() != previousHeight)

relayoutChildren = true;

- layoutPositionedObjects(relayoutChildren || isDocumentElement());

+ layoutPositionedObjects(relayoutChildren);

// FIXME: css3/flexbox/repaint-rtl-column.html seems to issue paint invalidations for more overflow than it needs to.

computeOverflow(clientLogicalBottomAfterRepositioning());