Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: sky/engine/core/rendering/RenderView.cpp

Issue 928393003: Remove the concept of document.documentElement (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderView.h ('k') | sky/engine/public/web/WebDocument.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderView.cpp
diff --git a/sky/engine/core/rendering/RenderView.cpp b/sky/engine/core/rendering/RenderView.cpp
index 869d0f41bdba0d57650c2bf52cd876e411130ee7..312b654e0fe45efe03235045c82d1fb90b2fe6bc 100644
--- a/sky/engine/core/rendering/RenderView.cpp
+++ b/sky/engine/core/rendering/RenderView.cpp
@@ -205,32 +205,11 @@ void RenderView::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset, Vec
paintObject(paintInfo, paintOffset, layers);
}
-static inline bool rendererObscuresBackground(RenderBox* rootBox)
-{
- ASSERT(rootBox);
- RenderStyle* style = rootBox->style();
- if (style->opacity() != 1
- || style->hasFilter()
- || style->hasTransform())
- return false;
-
- return true;
-}
-
void RenderView::paintBoxDecorationBackground(PaintInfo& paintInfo, const LayoutPoint&)
{
if (!view())
return;
- bool shouldPaintBackground = true;
- Node* documentElement = document().documentElement();
- if (RenderBox* rootBox = documentElement ? toRenderBox(documentElement->renderer()) : 0)
- shouldPaintBackground = !rendererObscuresBackground(rootBox);
-
- // If painting will entirely fill the view, no need to fill the background.
- if (!shouldPaintBackground)
- return;
-
// This code typically only executes if the root element's visibility has been set to hidden,
// if there is a transform on the <html>, or if there is a page scale factor less than 1.
// Only fill with the base background color (typically white) if we're the root document,
@@ -369,20 +348,6 @@ IntRect RenderView::unscaledDocumentRect() const
return pixelSnappedIntRect(layoutOverflowRect());
}
-bool RenderView::rootBackgroundIsEntirelyFixed() const
-{
- if (RenderObject* backgroundRenderer = this->backgroundRenderer())
- return backgroundRenderer->hasEntirelyFixedBackground();
- return false;
-}
-
-RenderObject* RenderView::backgroundRenderer() const
-{
- if (Element* documentElement = document().documentElement())
- return documentElement->renderer();
- return 0;
-}
-
LayoutRect RenderView::backgroundRect(RenderBox* backgroundRenderer) const
{
return unscaledDocumentRect();
@@ -420,20 +385,6 @@ LayoutUnit RenderView::viewLogicalHeightForPercentages() const
return viewLogicalHeight();
}
-void RenderView::updateHitTestResult(HitTestResult& result, const LayoutPoint& point)
-{
- if (result.innerNode())
- return;
-
- Node* node = document().documentElement();
- if (node) {
- result.setInnerNode(node);
- if (!result.innerNonSharedNode())
- result.setInnerNonSharedNode(node);
- result.setLocalPoint(point);
- }
-}
-
void RenderView::pushLayoutState(LayoutState& layoutState)
{
m_layoutState = &layoutState;
« no previous file with comments | « sky/engine/core/rendering/RenderView.h ('k') | sky/engine/public/web/WebDocument.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698