Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 914773002: Fix issue with super and computed property names (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix issue with super and computed property names We did not set up the [[HomeObject]] for properties created for computed property names. BUG=v8:3879 LOG=N R=dslomov@chromium.org Committed: https://crrev.com/b5e235661f105cc47a1000b8554d7b15f8d25e44 Cr-Commit-Position: refs/heads/master@{#26586}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -0 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/harmony/class-computed-property-names-super.js View 1 chunk +76 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/computed-property-names-super.js View 1 chunk +79 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 10 months ago (2015-02-10 22:38:51 UTC) #1
arv (Not doing code reviews)
https://codereview.chromium.org/914773002/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/914773002/diff/1/test/mjsunit/mjsunit.status#newcode121 test/mjsunit/mjsunit.status:121: 'harmony/computed-property-names-super': [PASS, NO_VARIANTS], I'll work on fixing this next. ...
5 years, 10 months ago (2015-02-10 22:43:12 UTC) #2
Dmitry Lomov (no reviews)
lgtm
5 years, 10 months ago (2015-02-11 15:09:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914773002/1
5 years, 10 months ago (2015-02-11 15:10:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 15:13:10 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 15:13:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5e235661f105cc47a1000b8554d7b15f8d25e44
Cr-Commit-Position: refs/heads/master@{#26586}

Powered by Google App Engine
This is Rietveld 408576698