Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: src/mips64/full-codegen-mips64.cc

Issue 914773002: Fix issue with super and computed property names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 1780 matching lines...) Expand 10 before | Expand all | Expand 10 after
1791 __ push(a0); 1791 __ push(a0);
1792 1792
1793 if (property->kind() == ObjectLiteral::Property::PROTOTYPE) { 1793 if (property->kind() == ObjectLiteral::Property::PROTOTYPE) {
1794 DCHECK(!property->is_computed_name()); 1794 DCHECK(!property->is_computed_name());
1795 VisitForStackValue(value); 1795 VisitForStackValue(value);
1796 DCHECK(property->emit_store()); 1796 DCHECK(property->emit_store());
1797 __ CallRuntime(Runtime::kInternalSetPrototype, 2); 1797 __ CallRuntime(Runtime::kInternalSetPrototype, 2);
1798 } else { 1798 } else {
1799 EmitPropertyKey(property, expr->GetIdForProperty(property_index)); 1799 EmitPropertyKey(property, expr->GetIdForProperty(property_index));
1800 VisitForStackValue(value); 1800 VisitForStackValue(value);
1801 EmitSetHomeObjectIfNeeded(value, 2);
1801 1802
1802 switch (property->kind()) { 1803 switch (property->kind()) {
1803 case ObjectLiteral::Property::CONSTANT: 1804 case ObjectLiteral::Property::CONSTANT:
1804 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1805 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1805 case ObjectLiteral::Property::COMPUTED: 1806 case ObjectLiteral::Property::COMPUTED:
1806 if (property->emit_store()) { 1807 if (property->emit_store()) {
1807 __ li(a0, Operand(Smi::FromInt(NONE))); 1808 __ li(a0, Operand(Smi::FromInt(NONE)));
1808 __ push(a0); 1809 __ push(a0);
1809 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked, 4); 1810 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked, 4);
1810 } else { 1811 } else {
(...skipping 3557 matching lines...) Expand 10 before | Expand all | Expand 10 after
5368 Assembler::target_address_at(pc_immediate_load_address)) == 5369 Assembler::target_address_at(pc_immediate_load_address)) ==
5369 reinterpret_cast<uint64_t>( 5370 reinterpret_cast<uint64_t>(
5370 isolate->builtins()->OsrAfterStackCheck()->entry())); 5371 isolate->builtins()->OsrAfterStackCheck()->entry()));
5371 return OSR_AFTER_STACK_CHECK; 5372 return OSR_AFTER_STACK_CHECK;
5372 } 5373 }
5373 5374
5374 5375
5375 } } // namespace v8::internal 5376 } } // namespace v8::internal
5376 5377
5377 #endif // V8_TARGET_ARCH_MIPS64 5378 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698