Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: test/mjsunit/harmony/computed-property-names-super.js

Issue 914773002: Fix issue with super and computed property names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/harmony/computed-property-names-super.js
diff --git a/test/mjsunit/harmony/computed-property-names-super.js b/test/mjsunit/harmony/computed-property-names-super.js
new file mode 100644
index 0000000000000000000000000000000000000000..096e0103172615f7e25a7518e31c0b967d54d14f
--- /dev/null
+++ b/test/mjsunit/harmony/computed-property-names-super.js
@@ -0,0 +1,79 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --harmony-computed-property-names --harmony-object-literals
+// Flags: --harmony-classes --allow-natives-syntax
+
+
+function ID(x) {
+ return x;
+}
+
+
+(function TestComputedMethodSuper() {
+ var proto = {
+ m() {
+ return ' proto m';
+ }
+ };
+ var object = {
+ __proto__: proto,
+ ['a']() { return 'a' + super.m(); },
+ [ID('b')]() { return 'b' + super.m(); },
+ [0]() { return '0' + super.m(); },
+ [ID(1)]() { return '1' + super.m(); },
+ };
+
+ assertSame(object, object.a[%HomeObjectSymbol()]);
+
+ assertEquals('a proto m', object.a());
+ assertEquals('b proto m', object.b());
+ assertEquals('0 proto m', object[0]());
+ assertEquals('1 proto m', object[1]());
+})();
+
+
+(function TestComputedGetterSuper() {
+ var proto = {
+ m() {
+ return ' proto m';
+ }
+ };
+ var object = {
+ __proto__: proto,
+ get ['a']() { return 'a' + super.m(); },
+ get [ID('b')]() { return 'b' + super.m(); },
+ get [0]() { return '0' + super.m(); },
+ get [ID(1)]() { return '1' + super.m(); },
+ };
+ assertEquals('a proto m', object.a);
+ assertEquals('b proto m', object.b);
+ assertEquals('0 proto m', object[0]);
+ assertEquals('1 proto m', object[1]);
+})();
+
+
+(function TestComputedSetterSuper() {
+ var value;
+ var proto = {
+ m(name, v) {
+ value = name + ' ' + v;
+ }
+ };
+ var object = {
+ __proto__: proto,
+ set ['a'](v) { super.m('a', v); },
+ set [ID('b')](v) { super.m('b', v); },
+ set [0](v) { super.m('0', v); },
+ set [ID(1)](v) { super.m('1', v); },
+ };
+ object.a = 2;
+ assertEquals('a 2', value);
+ object.b = 3;
+ assertEquals('b 3', value);
+ object[0] = 4;
+ assertEquals('0 4', value);
+ object[1] = 5;
+ assertEquals('1 5', value);
+})();

Powered by Google App Engine
This is Rietveld 408576698