Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: src/arm64/full-codegen-arm64.cc

Issue 914773002: Fix issue with super and computed property names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1779 matching lines...) Expand 10 before | Expand all | Expand 10 after
1790 __ Push(x10); 1790 __ Push(x10);
1791 1791
1792 if (property->kind() == ObjectLiteral::Property::PROTOTYPE) { 1792 if (property->kind() == ObjectLiteral::Property::PROTOTYPE) {
1793 DCHECK(!property->is_computed_name()); 1793 DCHECK(!property->is_computed_name());
1794 VisitForStackValue(value); 1794 VisitForStackValue(value);
1795 DCHECK(property->emit_store()); 1795 DCHECK(property->emit_store());
1796 __ CallRuntime(Runtime::kInternalSetPrototype, 2); 1796 __ CallRuntime(Runtime::kInternalSetPrototype, 2);
1797 } else { 1797 } else {
1798 EmitPropertyKey(property, expr->GetIdForProperty(property_index)); 1798 EmitPropertyKey(property, expr->GetIdForProperty(property_index));
1799 VisitForStackValue(value); 1799 VisitForStackValue(value);
1800 EmitSetHomeObjectIfNeeded(value, 2);
1800 1801
1801 switch (property->kind()) { 1802 switch (property->kind()) {
1802 case ObjectLiteral::Property::CONSTANT: 1803 case ObjectLiteral::Property::CONSTANT:
1803 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1804 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1804 case ObjectLiteral::Property::COMPUTED: 1805 case ObjectLiteral::Property::COMPUTED:
1805 if (property->emit_store()) { 1806 if (property->emit_store()) {
1806 __ Mov(x0, Smi::FromInt(NONE)); 1807 __ Mov(x0, Smi::FromInt(NONE));
1807 __ Push(x0); 1808 __ Push(x0);
1808 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked, 4); 1809 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked, 4);
1809 } else { 1810 } else {
(...skipping 3595 matching lines...) Expand 10 before | Expand all | Expand 10 after
5405 return previous_; 5406 return previous_;
5406 } 5407 }
5407 5408
5408 5409
5409 #undef __ 5410 #undef __
5410 5411
5411 5412
5412 } } // namespace v8::internal 5413 } } // namespace v8::internal
5413 5414
5414 #endif // V8_TARGET_ARCH_ARM64 5415 #endif // V8_TARGET_ARCH_ARM64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698