Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: src/x87/full-codegen-x87.cc

Issue 914773002: Fix issue with super and computed property names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1709 matching lines...) Expand 10 before | Expand all | Expand 10 after
1720 __ push(Operand(esp, 0)); // Duplicate receiver. 1720 __ push(Operand(esp, 0)); // Duplicate receiver.
1721 1721
1722 if (property->kind() == ObjectLiteral::Property::PROTOTYPE) { 1722 if (property->kind() == ObjectLiteral::Property::PROTOTYPE) {
1723 DCHECK(!property->is_computed_name()); 1723 DCHECK(!property->is_computed_name());
1724 VisitForStackValue(value); 1724 VisitForStackValue(value);
1725 DCHECK(property->emit_store()); 1725 DCHECK(property->emit_store());
1726 __ CallRuntime(Runtime::kInternalSetPrototype, 2); 1726 __ CallRuntime(Runtime::kInternalSetPrototype, 2);
1727 } else { 1727 } else {
1728 EmitPropertyKey(property, expr->GetIdForProperty(property_index)); 1728 EmitPropertyKey(property, expr->GetIdForProperty(property_index));
1729 VisitForStackValue(value); 1729 VisitForStackValue(value);
1730 EmitSetHomeObjectIfNeeded(value, 2);
1730 1731
1731 switch (property->kind()) { 1732 switch (property->kind()) {
1732 case ObjectLiteral::Property::CONSTANT: 1733 case ObjectLiteral::Property::CONSTANT:
1733 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1734 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1734 case ObjectLiteral::Property::COMPUTED: 1735 case ObjectLiteral::Property::COMPUTED:
1735 if (property->emit_store()) { 1736 if (property->emit_store()) {
1736 __ push(Immediate(Smi::FromInt(NONE))); 1737 __ push(Immediate(Smi::FromInt(NONE)));
1737 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked, 4); 1738 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked, 4);
1738 } else { 1739 } else {
1739 __ Drop(3); 1740 __ Drop(3);
(...skipping 3538 matching lines...) Expand 10 before | Expand all | Expand 10 after
5278 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5279 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5279 Assembler::target_address_at(call_target_address, 5280 Assembler::target_address_at(call_target_address,
5280 unoptimized_code)); 5281 unoptimized_code));
5281 return OSR_AFTER_STACK_CHECK; 5282 return OSR_AFTER_STACK_CHECK;
5282 } 5283 }
5283 5284
5284 5285
5285 } } // namespace v8::internal 5286 } } // namespace v8::internal
5286 5287
5287 #endif // V8_TARGET_ARCH_X87 5288 #endif // V8_TARGET_ARCH_X87
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698