Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 914773002: Fix issue with super and computed property names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | test/mjsunit/mjsunit.status » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1798 matching lines...) Expand 10 before | Expand all | Expand 10 after
1809 __ push(r0); 1809 __ push(r0);
1810 1810
1811 if (property->kind() == ObjectLiteral::Property::PROTOTYPE) { 1811 if (property->kind() == ObjectLiteral::Property::PROTOTYPE) {
1812 DCHECK(!property->is_computed_name()); 1812 DCHECK(!property->is_computed_name());
1813 VisitForStackValue(value); 1813 VisitForStackValue(value);
1814 DCHECK(property->emit_store()); 1814 DCHECK(property->emit_store());
1815 __ CallRuntime(Runtime::kInternalSetPrototype, 2); 1815 __ CallRuntime(Runtime::kInternalSetPrototype, 2);
1816 } else { 1816 } else {
1817 EmitPropertyKey(property, expr->GetIdForProperty(property_index)); 1817 EmitPropertyKey(property, expr->GetIdForProperty(property_index));
1818 VisitForStackValue(value); 1818 VisitForStackValue(value);
1819 EmitSetHomeObjectIfNeeded(value, 2);
1819 1820
1820 switch (property->kind()) { 1821 switch (property->kind()) {
1821 case ObjectLiteral::Property::CONSTANT: 1822 case ObjectLiteral::Property::CONSTANT:
1822 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1823 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1823 case ObjectLiteral::Property::COMPUTED: 1824 case ObjectLiteral::Property::COMPUTED:
1824 if (property->emit_store()) { 1825 if (property->emit_store()) {
1825 __ mov(r0, Operand(Smi::FromInt(NONE))); 1826 __ mov(r0, Operand(Smi::FromInt(NONE)));
1826 __ push(r0); 1827 __ push(r0);
1827 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked, 4); 1828 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked, 4);
1828 } else { 1829 } else {
(...skipping 3597 matching lines...) Expand 10 before | Expand all | Expand 10 after
5426 5427
5427 DCHECK(interrupt_address == 5428 DCHECK(interrupt_address ==
5428 isolate->builtins()->OsrAfterStackCheck()->entry()); 5429 isolate->builtins()->OsrAfterStackCheck()->entry());
5429 return OSR_AFTER_STACK_CHECK; 5430 return OSR_AFTER_STACK_CHECK;
5430 } 5431 }
5431 5432
5432 5433
5433 } } // namespace v8::internal 5434 } } // namespace v8::internal
5434 5435
5435 #endif // V8_TARGET_ARCH_ARM 5436 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | test/mjsunit/mjsunit.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698