Start piping Android app promos through AppBannerInfoBars

Start piping Android app promos through AppBannerInfoBars

* Use AppBannerInfoBars instead of AppBannerViews for Android
  app promos.

- Button doesn't install anything.

- Layout is still incorrect.

BUG=453170
Committed: https://crrev.com/56a3dba9f2fd45c1d736e6e57ddb81f1d3df05c7
Cr-Commit-Position: refs/heads/master@{#315104}

[gone, 2015-02-04 17:49:22]

dfalcantara@chromium.org changed reviewers:
+ newt@chromium.org

[gone, 2015-02-05 18:11:53]

Unsure if you've already started looking at this, but I'm squashing and
rearranging CLs.  The follow-up CL requires a bunch of changes that are better
folded into this one.

[gone, 2015-02-05 22:04:24]

dfalcantara@chromium.org changed reviewers:
+ tedchoc@chromium.org

[gone, 2015-02-05 22:04:25]

One big CL.  Could chop it up into two if it'd help the review, but we need all
of this together to get native app banners more or less working.

[gone, 2015-02-06 03:23:12]

Updated the CL to catch more of the special cases that the AppBannerView used to
catch.  Will try to split it up into two CLs.

[gone, 2015-02-06 03:49:57]

Broke the CL into two pieces.  This comes first and just handles the creation of
the infobar, while 871103004 lets the infobar actually do things.

PTAL

[gone, 2015-02-06 03:51:29]

+Ben as FYI

[Ted C, 2015-02-06 19:34:37]

lgtm

Depending on how this class progresses, we might want to split out the concept
of native vs web apps into separate classes to avoid constant if/elses, but this
seems fine for now.

https://chromiumcodereview.appspot.com/896243004/diff/150001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java
(right):

https://chromiumcodereview.appspot.com/896243004/diff/150001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java:29:
public AppBannerInfoBar(long nativeInfoBar, String appTitle, Bitmap iconBitmap,
AppData data) {
can these be private?  if not, we should document them better for consumption.

[gone, 2015-02-06 19:49:51]

New patchsets have been uploaded after l-g-t-m from tedchoc@chromium.org

[gone, 2015-02-06 20:04:32]

https://chromiumcodereview.appspot.com/896243004/diff/150001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java
(right):

https://chromiumcodereview.appspot.com/896243004/diff/150001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java:29:
public AppBannerInfoBar(long nativeInfoBar, String appTitle, Bitmap iconBitmap,
AppData data) {
On 2015/02/06 19:34:37, Ted C wrote:
> can these be private?  if not, we should document them better for consumption.

Done.

[gone, 2015-02-06 20:04:36]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2015-02-06 20:05:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/896243004/170001

[commit-bot: I haz the power, 2015-02-06 20:53:36]

Committed patchset #10 (id:170001)

[commit-bot: I haz the power, 2015-02-06 20:54:38]

Patchset 10 (id:??) landed as
https://crrev.com/56a3dba9f2fd45c1d736e6e57ddb81f1d3df05c7
Cr-Commit-Position: refs/heads/master@{#315104}