chrome/browser/android/banners/app_banner_infobar_delegate.h - Issue 896243004: Start piping Android app promos through AppBannerInfoBars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_infobar_delegate.h

Issue 896243004: Start piping Android app promos through AppBannerInfoBars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nits Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/strings/android_chrome_strings.grd ('k') | chrome/browser/android/banners/app_banner_infobar_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_infobar_delegate.h

diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate.h b/chrome/browser/android/banners/app_banner_infobar_delegate.h

index 5bc2e0a8ec9ccc43bb8a0ebbc69e9d39a58d8158..d08c211b12666197cf3247778bab9acb8eb79096 100644

--- a/chrome/browser/android/banners/app_banner_infobar_delegate.h

+++ b/chrome/browser/android/banners/app_banner_infobar_delegate.h

@@ -43,6 +43,13 @@ class AppBannerInfoBarDelegate : public ConfirmInfoBarDelegate {

virtual gfx::Image GetIcon() const = 0;

};

+ // Creates a banner for the current page that promotes a native app.

+ // May return nullptr if the the infobar couldn't be created.

+ static AppBannerInfoBar* CreateForNativeApp(

+ infobars::InfoBarManager* infobar_manager,

+ AppDelegate* delegate,

+ const base::android::ScopedJavaGlobalRef<jobject>& japp_data);

// Creates a banner for the current page that promotes a web app.

// May return nullptr if the the infobar couldn't be created.

static AppBannerInfoBar* CreateForWebApp(