Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1870)

Unified Diff: chrome/browser/android/banners/app_banner_manager.h

Issue 896243004: Start piping Android app promos through AppBannerInfoBars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nits Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager.h
diff --git a/chrome/browser/android/banners/app_banner_manager.h b/chrome/browser/android/banners/app_banner_manager.h
index b82ec7afe3273b6cfdf0fa6ad18eddb4559b5c39..736d9fa1f6ed64538a9de23216163f2696390916 100644
--- a/chrome/browser/android/banners/app_banner_manager.h
+++ b/chrome/browser/android/banners/app_banner_manager.h
@@ -85,11 +85,14 @@ class AppBannerManager : public chrome::BitmapFetcherDelegate,
jobject obj,
jobject jweb_contents);
- // Fetches the icon at the given URL asynchronously.
- // Returns |false| if this couldn't be kicked off.
- bool FetchIcon(JNIEnv* env,
- jobject obj,
- jstring jimage_url);
+ // Called when the Java-side has retrieved information for the app.
+ // Returns |false| if an icon fetch couldn't be kicked off.
+ bool OnAppDetailsRetrieved(JNIEnv* env,
+ jobject obj,
+ jobject japp_data,
+ jstring japp_title,
+ jstring japp_package,
+ jstring jicon_url);
// Fetches the icon at the given URL asynchronously.
// Returns |false| if this couldn't be kicked off.
@@ -155,6 +158,9 @@ class AppBannerManager : public chrome::BitmapFetcherDelegate,
content::Manifest web_app_data_;
+ base::android::ScopedJavaGlobalRef<jobject> native_app_data_;
+ std::string native_app_package_;
+
// Weak pointer to the InfoBar that is being managed.
AppBannerInfoBar* weak_infobar_ptr_;
« no previous file with comments | « chrome/browser/android/banners/app_banner_infobar_delegate.cc ('k') | chrome/browser/android/banners/app_banner_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698