Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java

Issue 896243004: Start piping Android app promos through AppBannerInfoBars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nits Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
index 564e70aa9991dd10025e02015370ffddfe821405..93e77435e2d12f68b0864a03b8d39c956be2694e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
@@ -61,6 +61,8 @@ import org.chromium.ui.base.WindowAndroid.IntentCallback;
* The layout of the banner, which includes its widget sizes, may change when the screen is rotated
* to account for less screen real estate. This means that all of the View's widgets and cached
* dimensions must be rebuilt from scratch.
+ *
+ * TODO(dfalcantara): Nuke this file.
*/
public class AppBannerView extends SwipableOverlayView
implements View.OnClickListener, InstallerDelegate.Observer, IntentCallback {
@@ -244,9 +246,7 @@ public class AppBannerView extends SwipableOverlayView
// Configure the controls with the package information.
mTitleView.setText(mAppData.title());
- mIconView.setImageDrawable(mAppData.icon());
mRatingView.initialize(mAppData.rating());
- setAccessibilityInformation();
// Determine how much the user can drag sideways before their touch is considered a scroll.
mTouchSlop = ViewConfiguration.get(getContext()).getScaledTouchSlop();
@@ -255,15 +255,6 @@ public class AppBannerView extends SwipableOverlayView
updateButtonStatus();
}
- /**
- * Creates a succinct description about the app being advertised.
- */
- private void setAccessibilityInformation() {
- String bannerText = getContext().getString(
- R.string.app_banner_view_accessibility, mAppData.title(), mAppData.rating());
- setContentDescription(bannerText);
- }
-
@Override
public void onClick(View view) {
if (mObserver == null) return;

Powered by Google App Engine
This is Rietveld 408576698