Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppData.java

Issue 896243004: Start piping Android app promos through AppBannerInfoBars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nits Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppData.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppData.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppData.java
index 2da22f5012e17f7df814e0f78d65742b28d20683..5960a06ecacfc35f11a6f5118e2271087abfdf01 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppData.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppData.java
@@ -5,7 +5,6 @@
package org.chromium.chrome.browser.banners;
import android.app.PendingIntent;
-import android.graphics.drawable.Drawable;
/**
* Stores information about a particular app.
@@ -23,9 +22,6 @@ public class AppData {
private PendingIntent mDetailsIntent;
private PendingIntent mInstallIntent;
- // Data that can be updated asynchronously.
- private Drawable mIcon;
-
/**
* Creates a new AppData for the given page and package.
* @param siteUrl URL for the site requesting the banner.
@@ -56,7 +52,7 @@ public class AppData {
* Returns the title to display for the app in the banner.
* @return The String to display.
*/
- String title() {
+ public String title() {
return mTitle;
}
@@ -69,18 +65,10 @@ public class AppData {
}
/**
- * Returns the Drawable depicting the app's icon.
- * @return The Drawable to use as the app icon.
- */
- Drawable icon() {
- return mIcon;
- }
-
- /**
* Returns how well the app was rated, on a scale from 0 to 5.
* @return The rating of the app.
*/
- float rating() {
+ public float rating() {
return mRating;
}
@@ -88,7 +76,7 @@ public class AppData {
* Returns text to display on the install button when the app is not installed on the system.
* @return The String to display.
*/
- String installButtonText() {
+ public String installButtonText() {
return mInstallButtonText;
}
@@ -97,7 +85,7 @@ public class AppData {
* The IntentSender stored inside dictates what package needs to be launched.
* @return Intent that triggers the details page.
*/
- PendingIntent detailsIntent() {
+ public PendingIntent detailsIntent() {
return mDetailsIntent;
}
@@ -128,12 +116,4 @@ public class AppData {
mDetailsIntent = detailsIntent;
mInstallIntent = installIntent;
}
-
- /**
- * Sets the icon used to depict the app.
- * @param Drawable App icon in Drawable form.
- */
- void setIcon(Drawable icon) {
- mIcon = icon;
- }
}

Powered by Google App Engine
This is Rietveld 408576698