chrome/android/java/strings/android_chrome_strings.grd - Issue 896243004: Start piping Android app promos through AppBannerInfoBars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 896243004: Start piping Android app promos through AppBannerInfoBars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nits Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java ('k') | chrome/browser/android/banners/app_banner_infobar_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/strings/android_chrome_strings.grd

diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd

index 41152dc964c75610fd0f5b2d6e593c337b0a8f70..e330f5d1c31e2cdbc1907ea5f98474b984ca7d21 100644

--- a/chrome/android/java/strings/android_chrome_strings.grd

+++ b/chrome/android/java/strings/android_chrome_strings.grd

@@ -829,7 +829,10 @@ You are signing in with a managed account and giving its administrator control o

</message>

- <message name="IDS_APP_BANNER_VIEW_ACCESSIBILITY" desc="Accessibililty text: Describes the banner content, including the app name and rating.">

+ <message name="IDS_APP_BANNER_VIEW_WEB_APP_ACCESSIBILITY" desc="Accessibililty text: Describes the banner content, including the app name and its URL.">

+ Prompt to add page to the homescreen. App name: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>. App URL: <ph name="APP_URL">%2$s<ex>http://gmail.com</ex></ph>.

+ </message>

+ <message name="IDS_APP_BANNER_VIEW_NATIVE_APP_ACCESSIBILITY" desc="Accessibililty text: Describes the banner content, including the app name and rating.">

Prompt to get app from the Google Play Store. App name: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>. App average rating: <ph name="APP_RATING">%2$.1f<ex>4.2</ex></ph>.

</message>