Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 894853007: [ServiceWorker] Update SWProviderHost::Focus() to return a Client. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sw_open_window
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index e767a3a94e731e1c207fa5b564dc7dfe259c0e9f..198a02dc76fd9eda28070fecb227b64b620fac9a 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -1247,7 +1247,7 @@ void ServiceWorkerVersion::OnPostMessageToDocument(
void ServiceWorkerVersion::OnFocusClient(int request_id, int client_id) {
TRACE_EVENT2("ServiceWorker",
- "ServiceWorkerVersion::OnFocusDocument",
+ "ServiceWorkerVersion::OnFocusClient",
"Request id", request_id,
"Client id", client_id);
ServiceWorkerProviderHost* provider_host =
@@ -1260,17 +1260,24 @@ void ServiceWorkerVersion::OnFocusClient(int request_id, int client_id) {
provider_host->Focus(
base::Bind(&ServiceWorkerVersion::OnFocusClientFinished,
weak_factory_.GetWeakPtr(),
- request_id));
+ request_id,
+ client_id));
}
-void ServiceWorkerVersion::OnFocusClientFinished(int request_id, bool result) {
+void ServiceWorkerVersion::OnFocusClientFinished(
+ int request_id,
+ int cliend_id,
+ const ServiceWorkerClientInfo& client) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (running_status() != RUNNING)
return;
+ ServiceWorkerClientInfo client_info(client);
+ client_info.client_id = cliend_id;
+
embedded_worker_->SendMessage(ServiceWorkerMsg_FocusClientResponse(
- request_id, result));
+ request_id, client_info));
}
void ServiceWorkerVersion::OnSkipWaiting(int request_id) {
« no previous file with comments | « content/browser/service_worker/service_worker_version.h ('k') | content/common/service_worker/service_worker_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698