Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1698)

Unified Diff: content/browser/service_worker/service_worker_provider_host.h

Issue 894853007: [ServiceWorker] Update SWProviderHost::Focus() to return a Client. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sw_open_window
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_provider_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_provider_host.h
diff --git a/content/browser/service_worker/service_worker_provider_host.h b/content/browser/service_worker/service_worker_provider_host.h
index 61b1c5e765f449b617e45ab63213bfa704d5f840..386bee2300e5d4aded72e9dd32c541e2d1c0ec04 100644
--- a/content/browser/service_worker/service_worker_provider_host.h
+++ b/content/browser/service_worker/service_worker_provider_host.h
@@ -45,7 +45,6 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
: public NON_EXPORTED_BASE(ServiceWorkerRegistration::Listener),
public base::SupportsWeakPtr<ServiceWorkerProviderHost> {
public:
- using FocusCallback = base::Callback<void(bool)>;
using GetClientInfoCallback =
base::Callback<void(const ServiceWorkerClientInfo&)>;
@@ -143,9 +142,8 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
// Activates the WebContents associated with
// { render_process_id_, render_frame_id_ }.
- // Runs the |callback| with the result in parameter describing whether the
- // focusing action was successful.
- void Focus(const FocusCallback& callback);
+ // Runs the |callback| with the updated ServiceWorkerClientInfo in parameter.
+ void Focus(const GetClientInfoCallback& callback);
// Asks the renderer to send back the document information.
void GetClientInfo(const GetClientInfoCallback& callback) const;
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_provider_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698