Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 894853007: [ServiceWorker] Update SWProviderHost::Focus() to return a Client. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sw_open_window
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_provider_host.cc
diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc
index a94d4d98a52bd0c6f1ed36f61c70ae980315753d..2926c75032d6893c2f084cb24acb59d0cd3bd7b3 100644
--- a/content/browser/service_worker/service_worker_provider_host.cc
+++ b/content/browser/service_worker/service_worker_provider_host.cc
@@ -5,6 +5,8 @@
#include "content/browser/service_worker/service_worker_provider_host.h"
#include "base/stl_util.h"
+#include "content/browser/frame_host/frame_tree.h"
+#include "content/browser/frame_host/frame_tree_node.h"
#include "content/browser/frame_host/render_frame_host_impl.h"
#include "content/browser/message_port_message_filter.h"
#include "content/browser/service_worker/service_worker_context_core.h"
@@ -15,35 +17,19 @@
#include "content/browser/service_worker/service_worker_registration_handle.h"
#include "content/browser/service_worker/service_worker_utils.h"
#include "content/browser/service_worker/service_worker_version.h"
+#include "content/browser/web_contents/web_contents_impl.h"
#include "content/common/resource_request_body.h"
#include "content/common/service_worker/service_worker_messages.h"
#include "content/common/service_worker/service_worker_types.h"
#include "content/public/browser/render_frame_host.h"
+#include "content/public/browser/render_widget_host_view.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/browser/web_contents_delegate.h"
#include "content/public/common/child_process_host.h"
namespace content {
namespace {
-void FocusOnUIThread(int render_process_id,
- int render_frame_id,
- const ServiceWorkerProviderHost::FocusCallback& callback) {
- WebContents* web_contents = WebContents::FromRenderFrameHost(
- RenderFrameHost::FromID(render_process_id, render_frame_id));
-
- bool result = false;
-
- if (web_contents && web_contents->GetDelegate()) {
- result = true;
- web_contents->GetDelegate()->ActivateContents(web_contents);
- }
-
- BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
- base::Bind(callback, result));
-}
-
void GetClientInfoOnUIThread(
int render_process_id,
int render_frame_id,
@@ -70,6 +56,35 @@ void GetClientInfoOnUIThread(
base::Bind(callback, client_info));
}
+void FocusOnUIThread(
+ int render_process_id,
+ int render_frame_id,
+ const ServiceWorkerProviderHost::GetClientInfoCallback& callback) {
+ RenderFrameHostImpl* render_frame_host =
+ RenderFrameHostImpl::FromID(render_process_id, render_frame_id);
+ WebContentsImpl* web_contents = static_cast<WebContentsImpl*>(
+ WebContents::FromRenderFrameHost(render_frame_host));
+
+ if (!render_frame_host || !web_contents) {
+ BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
+ base::Bind(callback, ServiceWorkerClientInfo()));
+ return;
+ }
+
+ FrameTreeNode* frame_tree_node = render_frame_host->frame_tree_node();
+
+ // Focus the frame in the frame tree node, in case it has changed.
+ frame_tree_node->frame_tree()->SetFocusedFrame(frame_tree_node);
+
+ // Focus the frame's view to make sure the frame is now considered as focused.
+ render_frame_host->GetView()->Focus();
+
+ // Move the web contents to the foreground.
+ web_contents->Activate();
+
+ GetClientInfoOnUIThread(render_process_id, render_frame_id, callback);
+}
+
} // anonymous namespace
ServiceWorkerProviderHost::ServiceWorkerProviderHost(
@@ -285,7 +300,7 @@ void ServiceWorkerProviderHost::PostMessage(
new_routing_ids));
}
-void ServiceWorkerProviderHost::Focus(const FocusCallback& callback) {
+void ServiceWorkerProviderHost::Focus(const GetClientInfoCallback& callback) {
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::Bind(&FocusOnUIThread,
« no previous file with comments | « content/browser/service_worker/service_worker_provider_host.h ('k') | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698