Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 889823002: Remove TRACE_EVENT indirection through blink::Platform (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel1, ojan
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove TRACE_EVENT indirection through blink::Platform Normal trace events already go directly to base. This CL removes the remaining trace events that were still indirected through blink::Platform. These were just the half-finished inspector timeline trace events, which currently aren't actually hooked up to anything. This CL also removes the redunant "convertable to trace format" wrappers and moves their one remaining use over to just using the version in base directly. R=eseidel@google.com, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7e84be6a0409db10a652c7d14446fc10ed559195

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1268 lines) Patch
M sky/engine/bindings/core/v8/ScriptController.cpp View 3 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/bindings/core/v8/V8Binding.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/bindings/core/v8/V8Binding.cpp View 2 chunks +0 lines, -26 lines 0 comments Download
M sky/engine/bindings/core/v8/V8GCController.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/Init.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 5 chunks +1 line, -12 lines 0 comments Download
M sky/engine/core/dom/Node.cpp View 4 chunks +25 lines, -10 lines 0 comments Download
M sky/engine/core/dom/ScriptedAnimationController.cpp View 3 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/events/EventDispatcher.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/frame/ConsoleBase.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/DOMTimer.cpp View 5 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 7 chunks +1 line, -16 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 3 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/html/parser/HTMLDocumentParser.cpp View 3 chunks +0 lines, -8 lines 0 comments Download
D sky/engine/core/inspector/InspectorTraceEvents.h View 1 chunk +0 lines, -127 lines 0 comments Download
D sky/engine/core/inspector/InspectorTraceEvents.cpp View 1 chunk +0 lines, -273 lines 0 comments Download
M sky/engine/core/loader/FrameFetchContext.cpp View 3 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/core/rendering/RenderImage.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/BUILD.gn View 3 chunks +0 lines, -6 lines 0 comments Download
D sky/engine/platform/EventTracer.h View 1 chunk +0 lines, -80 lines 0 comments Download
D sky/engine/platform/EventTracer.cpp View 1 chunk +0 lines, -84 lines 0 comments Download
M sky/engine/platform/TestingPlatformSupport.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/TestingPlatformSupport.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/engine/platform/TracedValue.h View 1 chunk +0 lines, -55 lines 0 comments Download
D sky/engine/platform/TracedValue.cpp View 1 chunk +0 lines, -142 lines 0 comments Download
D sky/engine/platform/TracedValueTest.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/platform/exported/WebConvertableToTraceFormat.cpp View 1 chunk +0 lines, -33 lines 0 comments Download
M sky/engine/platform/graphics/skia/NativeImageSkia.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/testing/RunAllTests.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/public/platform/Platform.h View 2 chunks +0 lines, -85 lines 0 comments Download
D sky/engine/public/platform/WebConvertableToTraceFormat.h View 1 chunk +0 lines, -42 lines 0 comments Download
M sky/engine/testing/platform/platform_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/testing/platform/platform_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/v8_inspector/InjectedScriptBase.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/v8_inspector/PageScriptDebugServer.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/viewer/platform/platform_impl.h View 1 chunk +0 lines, -27 lines 0 comments Download
M sky/viewer/platform/platform_impl.cc View 2 chunks +0 lines, -96 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-01-30 06:01:47 UTC) #1
eseidel1
lgtm
5 years, 10 months ago (2015-01-30 08:23:22 UTC) #3
abarth-chromium
5 years, 10 months ago (2015-01-30 16:47:50 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7e84be6a0409db10a652c7d14446fc10ed559195 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698