Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: sky/engine/bindings/core/v8/V8Binding.cpp

Issue 889823002: Remove TRACE_EVENT indirection through blink::Platform (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/core/v8/V8Binding.h ('k') | sky/engine/bindings/core/v8/V8GCController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/V8Binding.cpp
diff --git a/sky/engine/bindings/core/v8/V8Binding.cpp b/sky/engine/bindings/core/v8/V8Binding.cpp
index 7c323bb1fa453b734a5749f34059b3cc8aa9cc03..97903bd79738828853ae93b754b42eee2faaaf9e 100644
--- a/sky/engine/bindings/core/v8/V8Binding.cpp
+++ b/sky/engine/bindings/core/v8/V8Binding.cpp
@@ -43,9 +43,7 @@
#include "sky/engine/core/dom/QualifiedName.h"
#include "sky/engine/core/frame/LocalFrame.h"
#include "sky/engine/core/frame/Settings.h"
-#include "sky/engine/core/inspector/InspectorTraceEvents.h"
#include "sky/engine/core/loader/FrameLoaderClient.h"
-#include "sky/engine/platform/EventTracer.h"
#include "sky/engine/platform/JSONValues.h"
#include "sky/engine/wtf/ArrayBufferContents.h"
#include "sky/engine/wtf/MainThread.h"
@@ -836,28 +834,4 @@ v8::Isolate* V8TestingScope::isolate() const
return m_scriptState->isolate();
}
-void GetDevToolsFunctionInfo(v8::Handle<v8::Function> function, v8::Isolate* isolate, int& scriptId, String& resourceName, int& lineNumber)
-{
- v8::Handle<v8::Function> originalFunction = getBoundFunction(function);
- scriptId = originalFunction->ScriptId();
- v8::ScriptOrigin origin = originalFunction->GetScriptOrigin();
- if (!origin.ResourceName().IsEmpty()) {
- resourceName = NativeValueTraits<String>::nativeValue(origin.ResourceName(), isolate);
- lineNumber = originalFunction->GetScriptLineNumber() + 1;
- }
- if (resourceName.isEmpty()) {
- resourceName = "undefined";
- lineNumber = 1;
- }
-}
-
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> devToolsTraceEventData(ExecutionContext* context, v8::Handle<v8::Function> function, v8::Isolate* isolate)
-{
- int scriptId = 0;
- String resourceName;
- int lineNumber = 1;
- GetDevToolsFunctionInfo(function, isolate, scriptId, resourceName, lineNumber);
- return InspectorFunctionCallEvent::data(context, scriptId, resourceName, lineNumber);
-}
-
} // namespace blink
« no previous file with comments | « sky/engine/bindings/core/v8/V8Binding.h ('k') | sky/engine/bindings/core/v8/V8GCController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698