Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: sky/engine/platform/EventTracer.cpp

Issue 889823002: Remove TRACE_EVENT indirection through blink::Platform (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/platform/EventTracer.h ('k') | sky/engine/platform/TestingPlatformSupport.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/platform/EventTracer.cpp
diff --git a/sky/engine/platform/EventTracer.cpp b/sky/engine/platform/EventTracer.cpp
deleted file mode 100644
index 45438c727f62e05275ed536b7d50b6f80a4b52c5..0000000000000000000000000000000000000000
--- a/sky/engine/platform/EventTracer.cpp
+++ /dev/null
@@ -1,84 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "sky/engine/config.h"
-#include "sky/engine/platform/EventTracer.h"
-
-#include <stdio.h>
-#include "sky/engine/public/platform/Platform.h"
-#include "sky/engine/public/platform/WebConvertableToTraceFormat.h"
-#include "sky/engine/wtf/Assertions.h"
-
-namespace blink {
-
-COMPILE_ASSERT(sizeof(blink::Platform::TraceEventHandle) == sizeof(TraceEvent::TraceEventHandle), TraceEventHandle_types_must_be_compatible);
-
-const unsigned char* EventTracer::getTraceCategoryEnabledFlag(const char* categoryName)
-{
- static const char* dummyCategoryEnabledFlag = "*";
- // current() might not exist in unit tests.
- if (!blink::Platform::current())
- return reinterpret_cast<const unsigned char*>(dummyCategoryEnabledFlag);
-
- return blink::Platform::current()->getTraceCategoryEnabledFlag(categoryName);
-}
-
-TraceEvent::TraceEventHandle EventTracer::addTraceEvent(char phase, const unsigned char* categoryEnabledFlag,
- const char* name, unsigned long long id, int numArgs, const char* argNames[],
- const unsigned char argTypes[], const unsigned long long argValues[],
- TraceEvent::ConvertableToTraceFormat* convertableValues[],
- unsigned char flags)
-{
- blink::WebConvertableToTraceFormat webConvertableValues[2];
- if (numArgs <= static_cast<int>(WTF_ARRAY_LENGTH(webConvertableValues))) {
- for (int i = 0; i < numArgs; ++i) {
- if (convertableValues[i])
- webConvertableValues[i] = blink::WebConvertableToTraceFormat(convertableValues[i]);
- }
- } else {
- ASSERT_NOT_REACHED();
- }
- return blink::Platform::current()->addTraceEvent(phase, categoryEnabledFlag, name, id, numArgs, argNames, argTypes, argValues, webConvertableValues, flags);
-}
-
-TraceEvent::TraceEventHandle EventTracer::addTraceEvent(char phase, const unsigned char* categoryEnabledFlag,
- const char* name, unsigned long long id, int numArgs, const char** argNames,
- const unsigned char* argTypes, const unsigned long long* argValues,
- unsigned char flags)
-{
- return blink::Platform::current()->addTraceEvent(phase, categoryEnabledFlag, name, id, numArgs, argNames, argTypes, argValues, 0, flags);
-}
-
-void EventTracer::updateTraceEventDuration(const unsigned char* categoryEnabledFlag, const char* name, TraceEvent::TraceEventHandle handle)
-{
- blink::Platform::current()->updateTraceEventDuration(categoryEnabledFlag, name, handle);
-}
-
-} // namespace blink
« no previous file with comments | « sky/engine/platform/EventTracer.h ('k') | sky/engine/platform/TestingPlatformSupport.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698