Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: sky/engine/public/platform/Platform.h

Issue 889823002: Remove TRACE_EVENT indirection through blink::Platform (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/public/BUILD.gn ('k') | sky/engine/public/platform/WebConvertableToTraceFormat.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/public/platform/Platform.h
diff --git a/sky/engine/public/platform/Platform.h b/sky/engine/public/platform/Platform.h
index bf2528fb626af356c65765743242ccd16b70ac94..8d3ac0d24bf0797bbb8841b4033d3b8f2e838126 100644
--- a/sky/engine/public/platform/Platform.h
+++ b/sky/engine/public/platform/Platform.h
@@ -54,7 +54,6 @@ namespace blink {
class WebBlobRegistry;
class WebClipboard;
-class WebConvertableToTraceFormat;
class WebDiscardableMemory;
class WebFallbackThemeEngine;
class WebGraphicsContext3DProvider;
@@ -225,90 +224,6 @@ public:
// Tracing -------------------------------------------------------------
- // Get a pointer to the enabled state of the given trace category. The
- // embedder can dynamically change the enabled state as trace event
- // recording is started and stopped by the application. Only long-lived
- // literal strings should be given as the category name. The implementation
- // expects the returned pointer to be held permanently in a local static. If
- // the unsigned char is non-zero, tracing is enabled. If tracing is enabled,
- // addTraceEvent is expected to be called by the trace event macros.
- virtual const unsigned char* getTraceCategoryEnabledFlag(const char* categoryName) { return 0; }
-
- typedef uint64_t TraceEventHandle;
-
- // Add a trace event to the platform tracing system. Depending on the actual
- // enabled state, this event may be recorded or dropped.
- // - phase specifies the type of event:
- // - BEGIN ('B'): Marks the beginning of a scoped event.
- // - END ('E'): Marks the end of a scoped event.
- // - COMPLETE ('X'): Marks the beginning of a scoped event, but doesn't
- // need a matching END event. Instead, at the end of the scope,
- // updateTraceEventDuration() must be called with the TraceEventHandle
- // returned from addTraceEvent().
- // - INSTANT ('I'): Standalone, instantaneous event.
- // - START ('S'): Marks the beginning of an asynchronous event (the end
- // event can occur in a different scope or thread). The id parameter is
- // used to match START/FINISH pairs.
- // - FINISH ('F'): Marks the end of an asynchronous event.
- // - COUNTER ('C'): Used to trace integer quantities that change over
- // time. The argument values are expected to be of type int.
- // - METADATA ('M'): Reserved for internal use.
- // - categoryEnabled is the pointer returned by getTraceCategoryEnabledFlag.
- // - name is the name of the event. Also used to match BEGIN/END and
- // START/FINISH pairs.
- // - id optionally allows events of the same name to be distinguished from
- // each other. For example, to trace the consutruction and destruction of
- // objects, specify the pointer as the id parameter.
- // - numArgs specifies the number of elements in argNames, argTypes, and
- // argValues.
- // - argNames is the array of argument names. Use long-lived literal strings
- // or specify the COPY flag.
- // - argTypes is the array of argument types:
- // - BOOL (1): bool
- // - UINT (2): unsigned long long
- // - INT (3): long long
- // - DOUBLE (4): double
- // - POINTER (5): void*
- // - STRING (6): char* (long-lived null-terminated char* string)
- // - COPY_STRING (7): char* (temporary null-terminated char* string)
- // - CONVERTABLE (8): WebConvertableToTraceFormat
- // - argValues is the array of argument values. Each value is the unsigned
- // long long member of a union of all supported types.
- // - convertableValues is the array of WebConvertableToTraceFormat classes
- // that may be converted to trace format by calling asTraceFormat method.
- // ConvertableToTraceFormat interface.
- // - thresholdBeginId optionally specifies the value returned by a previous
- // call to addTraceEvent with a BEGIN phase.
- // - threshold is used on an END phase event in conjunction with the
- // thresholdBeginId of a prior BEGIN event. The threshold is the minimum
- // number of microseconds that must have passed since the BEGIN event. If
- // less than threshold microseconds has passed, the BEGIN/END pair is
- // dropped.
- // - flags can be 0 or one or more of the following, ORed together:
- // - COPY (0x1): treat all strings (name, argNames and argValues of type
- // string) as temporary so that they will be copied by addTraceEvent.
- // - HAS_ID (0x2): use the id argument to uniquely identify the event for
- // matching with other events of the same name.
- // - MANGLE_ID (0x4): specify this flag if the id parameter is the value
- // of a pointer.
- virtual TraceEventHandle addTraceEvent(
- char phase,
- const unsigned char* categoryEnabledFlag,
- const char* name,
- unsigned long long id,
- int numArgs,
- const char** argNames,
- const unsigned char* argTypes,
- const unsigned long long* argValues,
- const WebConvertableToTraceFormat* convertableValues,
- unsigned char flags)
- {
- return 0;
- }
-
- // Set the duration field of a COMPLETE trace event.
- virtual void updateTraceEventDuration(const unsigned char* categoryEnabledFlag, const char* name, TraceEventHandle) { }
-
// Callbacks for reporting histogram data.
// CustomCounts histogram has exponential bucket sizes, so that min=1, max=1000000, bucketCount=50 would do.
virtual void histogramCustomCounts(const char* name, int sample, int min, int max, int bucketCount) { }
« no previous file with comments | « sky/engine/public/BUILD.gn ('k') | sky/engine/public/platform/WebConvertableToTraceFormat.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698