Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: sky/engine/core/dom/Document.cpp

Issue 889823002: Remove TRACE_EVENT indirection through blink::Platform (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/core.gni ('k') | sky/engine/core/dom/Node.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/Document.cpp
diff --git a/sky/engine/core/dom/Document.cpp b/sky/engine/core/dom/Document.cpp
index 99639560dbc4046cc1e3b03dd2b5408a26598b9f..e881e611ff2917ea48b796b77f81e04eb04e7371 100644
--- a/sky/engine/core/dom/Document.cpp
+++ b/sky/engine/core/dom/Document.cpp
@@ -109,7 +109,6 @@
#include "sky/engine/core/html/parser/TextResourceDecoder.h"
#include "sky/engine/core/inspector/ConsoleMessage.h"
#include "sky/engine/core/inspector/InspectorCounters.h"
-#include "sky/engine/core/inspector/InspectorTraceEvents.h"
#include "sky/engine/core/loader/FrameLoaderClient.h"
#include "sky/engine/core/loader/ImageLoader.h"
#include "sky/engine/core/page/ChromeClient.h"
@@ -933,9 +932,6 @@ void Document::scheduleRenderTreeUpdate()
// TODO(esprehn): We should either rename this state, or change the other
// users of scheduleVisualUpdate() so they don't expect different states.
m_lifecycle.ensureStateAtMost(DocumentLifecycle::VisualUpdatePending);
-
- TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "ScheduleStyleRecalculation", TRACE_EVENT_SCOPE_PROCESS, "frame", frame());
- TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline.stack"), "CallStack", TRACE_EVENT_SCOPE_PROCESS, "stack", InspectorCallStackEvent::currentCallStack());
}
void Document::scheduleVisualUpdate()
@@ -1008,8 +1004,6 @@ void Document::updateRenderTree(StyleRecalcChange change)
TRACE_EVENT_SCOPED_SAMPLING_STATE("blink", "UpdateRenderTree");
m_styleRecalcElementCounter = 0;
- TRACE_EVENT_BEGIN1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "RecalculateStyles", "frame", frame());
- TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline.stack"), "CallStack", TRACE_EVENT_SCOPE_PROCESS, "stack", InspectorCallStackEvent::currentCallStack());
DocumentAnimations::updateOutdatedAnimationPlayersIfNeeded(*this);
evaluateMediaQueryListIfNeeded();
@@ -1028,9 +1022,6 @@ void Document::updateRenderTree(StyleRecalcChange change)
clearFocusedElementSoon();
ASSERT(!m_timeline->hasOutdatedAnimationPlayer());
-
- TRACE_EVENT_END1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "RecalculateStyles", "elementCount", m_styleRecalcElementCounter);
- TRACE_EVENT_END1("blink", "Document::updateRenderTree", "elementCount", m_styleRecalcElementCounter);
}
void Document::updateStyle(StyleRecalcChange change)
@@ -2053,10 +2044,8 @@ void Document::finishedParsing()
// Keep it alive until we are done.
RefPtr<Document> protect(this);
- if (RefPtr<LocalFrame> f = frame()) {
+ if (RefPtr<LocalFrame> f = frame())
checkCompleted();
- TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "MarkDOMContent", TRACE_EVENT_SCOPE_PROCESS, "data", InspectorMarkLoadEvent::data());
- }
// Schedule dropping of the ElementDataCache. We keep it alive for a while after parsing finishes
// so that dynamically inserted content can also benefit from sharing optimizations.
« no previous file with comments | « sky/engine/core/core.gni ('k') | sky/engine/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698