Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: sky/engine/bindings/core/v8/V8GCController.cpp

Issue 889823002: Remove TRACE_EVENT indirection through blink::Platform (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/core/v8/V8Binding.cpp ('k') | sky/engine/core/Init.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/V8GCController.cpp
diff --git a/sky/engine/bindings/core/v8/V8GCController.cpp b/sky/engine/bindings/core/v8/V8GCController.cpp
index 40531346a24300e0f933365cfc84d827e2e2b440..7903cc3c4522c421e2a1e535b67758a156ac825c 100644
--- a/sky/engine/bindings/core/v8/V8GCController.cpp
+++ b/sky/engine/bindings/core/v8/V8GCController.cpp
@@ -48,7 +48,6 @@
#include "sky/engine/core/html/HTMLImageElement.h"
#include "sky/engine/core/html/HTMLTemplateElement.h"
#include "sky/engine/core/html/imports/HTMLImportsController.h"
-#include "sky/engine/core/inspector/InspectorTraceEvents.h"
#include "sky/engine/platform/Partitions.h"
#include "sky/engine/platform/TraceEvent.h"
#include "sky/engine/wtf/Vector.h"
@@ -303,18 +302,10 @@ private:
bool m_constructRetainedObjectInfos;
};
-static unsigned long long usedHeapSize(v8::Isolate* isolate)
-{
- v8::HeapStatistics heapStatistics;
- isolate->GetHeapStatistics(&heapStatistics);
- return heapStatistics.used_heap_size();
-}
-
void V8GCController::gcPrologue(v8::GCType type, v8::GCCallbackFlags flags)
{
// FIXME: It would be nice if the GC callbacks passed the Isolate directly....
v8::Isolate* isolate = v8::Isolate::GetCurrent();
- TRACE_EVENT_BEGIN1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "GCEvent", "usedHeapSizeBefore", usedHeapSize(isolate));
if (type == v8::kGCTypeScavenge)
minorGCPrologue(isolate);
else if (type == v8::kGCTypeMarkSweepCompact)
@@ -368,9 +359,6 @@ void V8GCController::gcEpilogue(v8::GCType type, v8::GCCallbackFlags flags)
minorGCEpilogue(isolate);
else if (type == v8::kGCTypeMarkSweepCompact)
majorGCEpilogue(isolate);
-
- TRACE_EVENT_END1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "GCEvent", "usedHeapSizeAfter", usedHeapSize(isolate));
- TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "UpdateCounters", TRACE_EVENT_SCOPE_PROCESS, "data", InspectorUpdateCountersEvent::data());
}
void V8GCController::minorGCEpilogue(v8::Isolate* isolate)
« no previous file with comments | « sky/engine/bindings/core/v8/V8Binding.cpp ('k') | sky/engine/core/Init.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698