Issue 881303002: [turbofan] Add missing deopt for the assignment in the for-in statement.

Issue 881303002: [turbofan] Add missing deopt for the assignment in the for-in statement. (Closed)

Created:
5 years, 10 months ago by Jarin

Modified:
5 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Add missing deopt for the assignment in the for-in statement. BUG=chromium:416359 LOG=n R=mstarzinger@chromium.org Committed: https://crrev.com/489b6f7c6055cc208410b8bd9cf81deb89ddc26a Cr-Commit-Position: refs/heads/master@{#26309}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -15 lines)			Patch
M	src/arm/full-codegen-arm.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm64/full-codegen-arm64.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ast.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/compiler/ast-graph-builder.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/compiler/ast-graph-builder.cc	View		5 chunks	+6 lines, -8 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mips64/full-codegen-mips64.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ppc/full-codegen-ppc.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x87/full-codegen-x87.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	test/mjsunit/compiler/regress-416359.js	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881303002/20001

5 years, 10 months ago (2015-01-28 15:48:29 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-01-28 16:16:33 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/489b6f7c6055cc208410b8bd9cf81deb89ddc26a
Cr-Commit-Position: refs/heads/master@{#26309}