Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 881303002: [turbofan] Add missing deopt for the assignment in the for-in statement. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add test. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 1229 matching lines...) Expand 10 before | Expand all | Expand 10 after
1240 __ mov(a3, result_register()); 1240 __ mov(a3, result_register());
1241 __ Branch(loop_statement.continue_label(), eq, a3, Operand(zero_reg)); 1241 __ Branch(loop_statement.continue_label(), eq, a3, Operand(zero_reg));
1242 1242
1243 // Update the 'each' property or variable from the possibly filtered 1243 // Update the 'each' property or variable from the possibly filtered
1244 // entry in register a3. 1244 // entry in register a3.
1245 __ bind(&update_each); 1245 __ bind(&update_each);
1246 __ mov(result_register(), a3); 1246 __ mov(result_register(), a3);
1247 // Perform the assignment as if via '='. 1247 // Perform the assignment as if via '='.
1248 { EffectContext context(this); 1248 { EffectContext context(this);
1249 EmitAssignment(stmt->each()); 1249 EmitAssignment(stmt->each());
1250 PrepareForBailoutForId(stmt->AssignmentId(), NO_REGISTERS);
1250 } 1251 }
1251 1252
1252 // Generate code for the body of the loop. 1253 // Generate code for the body of the loop.
1253 Visit(stmt->body()); 1254 Visit(stmt->body());
1254 1255
1255 // Generate code for the going to the next element by incrementing 1256 // Generate code for the going to the next element by incrementing
1256 // the index (smi) stored on top of the stack. 1257 // the index (smi) stored on top of the stack.
1257 __ bind(loop_statement.continue_label()); 1258 __ bind(loop_statement.continue_label());
1258 __ pop(a0); 1259 __ pop(a0);
1259 __ Addu(a0, a0, Operand(Smi::FromInt(1))); 1260 __ Addu(a0, a0, Operand(Smi::FromInt(1)));
(...skipping 4088 matching lines...) Expand 10 before | Expand all | Expand 10 after
5348 Assembler::target_address_at(pc_immediate_load_address)) == 5349 Assembler::target_address_at(pc_immediate_load_address)) ==
5349 reinterpret_cast<uint32_t>( 5350 reinterpret_cast<uint32_t>(
5350 isolate->builtins()->OsrAfterStackCheck()->entry())); 5351 isolate->builtins()->OsrAfterStackCheck()->entry()));
5351 return OSR_AFTER_STACK_CHECK; 5352 return OSR_AFTER_STACK_CHECK;
5352 } 5353 }
5353 5354
5354 5355
5355 } } // namespace v8::internal 5356 } } // namespace v8::internal
5356 5357
5357 #endif // V8_TARGET_ARCH_MIPS 5358 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698