Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 881303002: [turbofan] Add missing deopt for the assignment in the for-in statement. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add test. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1166 matching lines...) Expand 10 before | Expand all | Expand 10 after
1177 __ j(equal, loop_statement.continue_label()); 1177 __ j(equal, loop_statement.continue_label());
1178 __ mov(ebx, eax); 1178 __ mov(ebx, eax);
1179 1179
1180 // Update the 'each' property or variable from the possibly filtered 1180 // Update the 'each' property or variable from the possibly filtered
1181 // entry in register ebx. 1181 // entry in register ebx.
1182 __ bind(&update_each); 1182 __ bind(&update_each);
1183 __ mov(result_register(), ebx); 1183 __ mov(result_register(), ebx);
1184 // Perform the assignment as if via '='. 1184 // Perform the assignment as if via '='.
1185 { EffectContext context(this); 1185 { EffectContext context(this);
1186 EmitAssignment(stmt->each()); 1186 EmitAssignment(stmt->each());
1187 PrepareForBailoutForId(stmt->AssignmentId(), NO_REGISTERS);
1187 } 1188 }
1188 1189
1189 // Generate code for the body of the loop. 1190 // Generate code for the body of the loop.
1190 Visit(stmt->body()); 1191 Visit(stmt->body());
1191 1192
1192 // Generate code for going to the next element by incrementing the 1193 // Generate code for going to the next element by incrementing the
1193 // index (smi) stored on top of the stack. 1194 // index (smi) stored on top of the stack.
1194 __ bind(loop_statement.continue_label()); 1195 __ bind(loop_statement.continue_label());
1195 __ add(Operand(esp, 0 * kPointerSize), Immediate(Smi::FromInt(1))); 1196 __ add(Operand(esp, 0 * kPointerSize), Immediate(Smi::FromInt(1)));
1196 1197
(...skipping 4085 matching lines...) Expand 10 before | Expand all | Expand 10 after
5282 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5283 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5283 Assembler::target_address_at(call_target_address, 5284 Assembler::target_address_at(call_target_address,
5284 unoptimized_code)); 5285 unoptimized_code));
5285 return OSR_AFTER_STACK_CHECK; 5286 return OSR_AFTER_STACK_CHECK;
5286 } 5287 }
5287 5288
5288 5289
5289 } } // namespace v8::internal 5290 } } // namespace v8::internal
5290 5291
5291 #endif // V8_TARGET_ARCH_IA32 5292 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698