Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: src/arm64/full-codegen-arm64.cc

Issue 881303002: [turbofan] Add missing deopt for the assignment in the for-in statement. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add test. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ast.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1229 matching lines...) Expand 10 before | Expand all | Expand 10 after
1240 __ Mov(x3, x0); 1240 __ Mov(x3, x0);
1241 __ Cbz(x0, loop_statement.continue_label()); 1241 __ Cbz(x0, loop_statement.continue_label());
1242 1242
1243 // Update the 'each' property or variable from the possibly filtered 1243 // Update the 'each' property or variable from the possibly filtered
1244 // entry in register x3. 1244 // entry in register x3.
1245 __ Bind(&update_each); 1245 __ Bind(&update_each);
1246 __ Mov(result_register(), x3); 1246 __ Mov(result_register(), x3);
1247 // Perform the assignment as if via '='. 1247 // Perform the assignment as if via '='.
1248 { EffectContext context(this); 1248 { EffectContext context(this);
1249 EmitAssignment(stmt->each()); 1249 EmitAssignment(stmt->each());
1250 PrepareForBailoutForId(stmt->AssignmentId(), NO_REGISTERS);
1250 } 1251 }
1251 1252
1252 // Generate code for the body of the loop. 1253 // Generate code for the body of the loop.
1253 Visit(stmt->body()); 1254 Visit(stmt->body());
1254 1255
1255 // Generate code for going to the next element by incrementing 1256 // Generate code for going to the next element by incrementing
1256 // the index (smi) stored on top of the stack. 1257 // the index (smi) stored on top of the stack.
1257 __ Bind(loop_statement.continue_label()); 1258 __ Bind(loop_statement.continue_label());
1258 // TODO(all): We could use a callee saved register to avoid popping. 1259 // TODO(all): We could use a callee saved register to avoid popping.
1259 __ Pop(x0); 1260 __ Pop(x0);
(...skipping 4130 matching lines...) Expand 10 before | Expand all | Expand 10 after
5390 return previous_; 5391 return previous_;
5391 } 5392 }
5392 5393
5393 5394
5394 #undef __ 5395 #undef __
5395 5396
5396 5397
5397 } } // namespace v8::internal 5398 } } // namespace v8::internal
5398 5399
5399 #endif // V8_TARGET_ARCH_ARM64 5400 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ast.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698