src/mips64/full-codegen-mips64.cc - Issue 881303002: [turbofan] Add missing deopt for the assignment in the for-in statement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips64/full-codegen-mips64.cc

Issue 881303002: [turbofan] Add missing deopt for the assignment in the for-in statement. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add test. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips64/full-codegen-mips64.cc

diff --git a/src/mips64/full-codegen-mips64.cc b/src/mips64/full-codegen-mips64.cc

index 733ff81f8e759f7ea560755f3229e1645911383a..83bcf0356edf1b2f8ea17a9be4ba2933a68dd235 100644

--- a/src/mips64/full-codegen-mips64.cc

+++ b/src/mips64/full-codegen-mips64.cc

@@ -1242,6 +1242,7 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

// Perform the assignment as if via '='.

{ EffectContext context(this);

EmitAssignment(stmt->each());

+ PrepareForBailoutForId(stmt->AssignmentId(), NO_REGISTERS);

}

// Generate code for the body of the loop.

« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »