Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1557)

Side by Side Diff: src/mips64/full-codegen-mips64.cc

Issue 881303002: [turbofan] Add missing deopt for the assignment in the for-in statement. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add test. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 1224 matching lines...) Expand 10 before | Expand all | Expand 10 after
1235 __ mov(a3, result_register()); 1235 __ mov(a3, result_register());
1236 __ Branch(loop_statement.continue_label(), eq, a3, Operand(zero_reg)); 1236 __ Branch(loop_statement.continue_label(), eq, a3, Operand(zero_reg));
1237 1237
1238 // Update the 'each' property or variable from the possibly filtered 1238 // Update the 'each' property or variable from the possibly filtered
1239 // entry in register a3. 1239 // entry in register a3.
1240 __ bind(&update_each); 1240 __ bind(&update_each);
1241 __ mov(result_register(), a3); 1241 __ mov(result_register(), a3);
1242 // Perform the assignment as if via '='. 1242 // Perform the assignment as if via '='.
1243 { EffectContext context(this); 1243 { EffectContext context(this);
1244 EmitAssignment(stmt->each()); 1244 EmitAssignment(stmt->each());
1245 PrepareForBailoutForId(stmt->AssignmentId(), NO_REGISTERS);
1245 } 1246 }
1246 1247
1247 // Generate code for the body of the loop. 1248 // Generate code for the body of the loop.
1248 Visit(stmt->body()); 1249 Visit(stmt->body());
1249 1250
1250 // Generate code for the going to the next element by incrementing 1251 // Generate code for the going to the next element by incrementing
1251 // the index (smi) stored on top of the stack. 1252 // the index (smi) stored on top of the stack.
1252 __ bind(loop_statement.continue_label()); 1253 __ bind(loop_statement.continue_label());
1253 __ pop(a0); 1254 __ pop(a0);
1254 __ Daddu(a0, a0, Operand(Smi::FromInt(1))); 1255 __ Daddu(a0, a0, Operand(Smi::FromInt(1)));
(...skipping 4097 matching lines...) Expand 10 before | Expand all | Expand 10 after
5352 Assembler::target_address_at(pc_immediate_load_address)) == 5353 Assembler::target_address_at(pc_immediate_load_address)) ==
5353 reinterpret_cast<uint64_t>( 5354 reinterpret_cast<uint64_t>(
5354 isolate->builtins()->OsrAfterStackCheck()->entry())); 5355 isolate->builtins()->OsrAfterStackCheck()->entry()));
5355 return OSR_AFTER_STACK_CHECK; 5356 return OSR_AFTER_STACK_CHECK;
5356 } 5357 }
5357 5358
5358 5359
5359 } } // namespace v8::internal 5360 } } // namespace v8::internal
5360 5361
5361 #endif // V8_TARGET_ARCH_MIPS64 5362 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698