Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 879733002: Replace createTextNode with new Text(). (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Replace createTextNode with new Text(). Sky doesn't have this method (per spec). R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/37f1aca4eb87ee9e313b3a0a788f72ec1a84bd66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -24 lines) Patch
M sky/benchmarks/dom/creation.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/benchmarks/layout/simple-blocks.sky View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Document.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M sky/engine/core/dom/Document.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/editing/InsertLineBreakCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/html/HTMLTitleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/editing/delete_block_contents.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/delivery-order.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/mutation-observer/mutation-callback-non-element-crash.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/mutation-observer/mutation-record-nullity.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/mutation-observer/observe-characterdata.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/mutation-observer/observe-options-character-data.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/mutation-observer/shadow-dom.sky View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
Does this bring us closer to ian's spec? Can you link to such? :) overall ...
5 years, 11 months ago (2015-01-26 22:34:19 UTC) #2
esprehn
On 2015/01/26 at 22:34:19, eseidel wrote: > Does this bring us closer to ian's spec? ...
5 years, 11 months ago (2015-01-26 23:07:07 UTC) #3
esprehn
5 years, 11 months ago (2015-01-26 23:12:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37f1aca4eb87ee9e313b3a0a788f72ec1a84bd66 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698