sky/engine/core/html/HTMLTitleElement.cpp - Issue 879733002: Replace createTextNode with new Text().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/engine/core/html/HTMLTitleElement.cpp

Issue 879733002: Replace createTextNode with new Text(). (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « sky/engine/core/editing/InsertLineBreakCommand.cpp ('k') | sky/tests/editing/delete_block_contents.sky » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2001 Dirk Mueller (mueller@kde.org)	4 * (C) 2001 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2003, 2010 Apple Inc. All rights reserved.	5 * Copyright (C) 2003, 2010 Apple Inc. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 68 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
79 {	79 {

80 RefPtr<Node> protectFromMutationEvents(this);	80 RefPtr<Node> protectFromMutationEvents(this);

81 ChildListMutationScope mutation(*this);	81 ChildListMutationScope mutation(*this);

82	82

83 // Avoid calling Document::setTitleElement() during intermediate steps.	83 // Avoid calling Document::setTitleElement() during intermediate steps.

84 m_ignoreTitleUpdatesWhenChildrenChange = !value.isEmpty();	84 m_ignoreTitleUpdatesWhenChildrenChange = !value.isEmpty();

85 removeChildren();	85 removeChildren();

86 m_ignoreTitleUpdatesWhenChildrenChange = false;	86 m_ignoreTitleUpdatesWhenChildrenChange = false;

87	87

88 if (!value.isEmpty())	88 if (!value.isEmpty())

89 appendChild(document().createTextNode(value.impl()), IGNORE_EXCEPTION);	89 appendChild(Text::create(document(), value.impl()), IGNORE_EXCEPTION);

90 }	90 }

91	91

92 }	92 }

OLD	NEW