sky/tests/mutation-observer/mutation-callback-non-element-crash.sky - Issue 879733002: Replace createTextNode with new Text().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/tests/mutation-observer/mutation-callback-non-element-crash.sky

Issue 879733002: Replace createTextNode with new Text(). (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/tests/mutation-observer/mutation-callback-non-element-crash.sky

diff --git a/sky/tests/mutation-observer/mutation-callback-non-element-crash.sky b/sky/tests/mutation-observer/mutation-callback-non-element-crash.sky

index a6c4ff401d4774097a7b7027f952b8ba89e5e07c..89450e7fb10517c7c9774560fc2d467c194a64b7 100644

--- a/sky/tests/mutation-observer/mutation-callback-non-element-crash.sky

+++ b/sky/tests/mutation-observer/mutation-callback-non-element-crash.sky

@@ -9,7 +9,7 @@ function mutationCallback(mutations, observer) {

var mutationObserver = new MutationObserver(mutationCallback);

var body = document.getElementById("body");

mutationObserver.observe(body, {childList: true});

-body.appendChild(document.createTextNode("PASS. We didn't crash"));

+body.appendChild(new Text("PASS. We didn't crash"));

</script>

</body>

</html>

« no previous file with comments | « sky/tests/mutation-observer/delivery-order.sky ('k') | sky/tests/mutation-observer/mutation-record-nullity.sky » ('j') | no next file with comments »