Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: sky/engine/core/dom/Node.cpp

Issue 879733002: Replace createTextNode with new Text(). (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/dom/Document.idl ('k') | sky/engine/core/editing/InsertLineBreakCommand.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 901 matching lines...) Expand 10 before | Expand all | Expand 10 after
912 // See crbug.com/352836 also. 912 // See crbug.com/352836 also.
913 // No need to do anything if the text is identical. 913 // No need to do anything if the text is identical.
914 if (container->hasOneTextChild() && toText(container->firstChild())- >data() == text) 914 if (container->hasOneTextChild() && toText(container->firstChild())- >data() == text)
915 return; 915 return;
916 916
917 ChildListMutationScope mutation(*this); 917 ChildListMutationScope mutation(*this);
918 container->removeChildren(); 918 container->removeChildren();
919 // Note: This API will not insert empty text nodes: 919 // Note: This API will not insert empty text nodes:
920 // http://dom.spec.whatwg.org/#dom-node-textcontent 920 // http://dom.spec.whatwg.org/#dom-node-textcontent
921 if (!text.isEmpty()) 921 if (!text.isEmpty())
922 container->appendChild(document().createTextNode(text), ASSERT_N O_EXCEPTION); 922 container->appendChild(Text::create(document(), text), ASSERT_NO _EXCEPTION);
923 return; 923 return;
924 } 924 }
925 case DOCUMENT_NODE: 925 case DOCUMENT_NODE:
926 // FIXME(sky): When we get rid of the Document being special, go dow n the ELEMENT_NODE codepath. 926 // FIXME(sky): When we get rid of the Document being special, go dow n the ELEMENT_NODE codepath.
927 // Do nothing. 927 // Do nothing.
928 return; 928 return;
929 } 929 }
930 } 930 }
931 931
932 bool Node::offsetInCharacters() const 932 bool Node::offsetInCharacters() const
(...skipping 706 matching lines...) Expand 10 before | Expand all | Expand 10 after
1639 node->showTreeForThis(); 1639 node->showTreeForThis();
1640 } 1640 }
1641 1641
1642 void showNodePath(const blink::Node* node) 1642 void showNodePath(const blink::Node* node)
1643 { 1643 {
1644 if (node) 1644 if (node)
1645 node->showNodePathForThis(); 1645 node->showNodePathForThis();
1646 } 1646 }
1647 1647
1648 #endif 1648 #endif
OLDNEW
« no previous file with comments | « sky/engine/core/dom/Document.idl ('k') | sky/engine/core/editing/InsertLineBreakCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698