sky/engine/core/dom/Node.cpp - Issue 879733002: Replace createTextNode with new Text().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/dom/Node.cpp

Issue 879733002: Replace createTextNode with new Text(). (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/dom/Node.cpp

diff --git a/sky/engine/core/dom/Node.cpp b/sky/engine/core/dom/Node.cpp

index 4ebaf10edf2cb266fe02aeb717eb8ba41540ad1b..c6986da84f8b71cfffa2d28006aec482cfac90b5 100644

--- a/sky/engine/core/dom/Node.cpp

+++ b/sky/engine/core/dom/Node.cpp

@@ -919,7 +919,7 @@ void Node::setTextContent(const String& text)

// Note: This API will not insert empty text nodes:

// http://dom.spec.whatwg.org/#dom-node-textcontent

if (!text.isEmpty())

- container->appendChild(document().createTextNode(text), ASSERT_NO_EXCEPTION);

+ container->appendChild(Text::create(document(), text), ASSERT_NO_EXCEPTION);

return;

}

case DOCUMENT_NODE:

« no previous file with comments | « sky/engine/core/dom/Document.idl ('k') | sky/engine/core/editing/InsertLineBreakCommand.cpp » ('j') | no next file with comments »