sky/engine/core/html/HTMLTitleElement.cpp - Issue 879733002: Replace createTextNode with new Text().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/html/HTMLTitleElement.cpp

Issue 879733002: Replace createTextNode with new Text(). (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/html/HTMLTitleElement.cpp

diff --git a/sky/engine/core/html/HTMLTitleElement.cpp b/sky/engine/core/html/HTMLTitleElement.cpp

index ca7e43229a668bca7db3a8849da40696af18f735..e2419cc48a0d1a6470b6cda8f22fba15df201f57 100644

--- a/sky/engine/core/html/HTMLTitleElement.cpp

+++ b/sky/engine/core/html/HTMLTitleElement.cpp

@@ -86,7 +86,7 @@ void HTMLTitleElement::setText(const String &value)

m_ignoreTitleUpdatesWhenChildrenChange = false;

if (!value.isEmpty())

- appendChild(document().createTextNode(value.impl()), IGNORE_EXCEPTION);

+ appendChild(Text::create(document(), value.impl()), IGNORE_EXCEPTION);

}