Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 85463005: remove SkFloatToScalar macro (Closed)

Created:
7 years ago by caryclark
Modified:
7 years ago
Reviewers:
djsollen, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

remove SkFloatToScalar macro BUG= Committed: http://code.google.com/p/skia/source/detail?r=12385

Patch Set 1 #

Patch Set 2 : remove test output change #

Patch Set 3 : add failing test back #

Total comments: 1

Patch Set 4 : add flag to expose SkFloatToScalar to chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+442 lines, -437 lines) Patch
M bench/AAClipBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/BicubicBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BlurBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/BlurImageFilterBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/BlurRectBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/ColorFilterBench.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M bench/MatrixBench.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M bench/MatrixConvolutionBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/MorphologyBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/RectBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M experimental/DrawingBoard/SampleDrawingClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M experimental/PdfViewer/src/SkPdfRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/blurrect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/blurroundrect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/colorfilterimagefilter.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M gm/colormatrix.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/complexclip.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/complexclip2.cpp View 1 chunk +13 lines, -13 lines 0 comments Download
M gm/convexpaths.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M gm/dashing.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradient_matrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradients.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M gm/hairlines.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/matrixconvolution.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/ovals.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/perlinnoise.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/roundrects.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/shaderbounds.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M gm/simpleaaclip.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M gyp/common.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkDocument.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkScalar.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M samplecode/ClockFaceView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleAARects.cpp View 1 chunk +48 lines, -48 lines 0 comments Download
M samplecode/SampleAll.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SampleApp.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleArc.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleDegenerateTwoPtRadials.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleDither.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleEffects.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SampleFilter2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleFontScalerTest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M samplecode/SampleHairline.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SamplePicture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePolyToPoly.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M samplecode/SampleRegion.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleSlides.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleTextOnPath.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M samplecode/TransitionView.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/vertexdump.cpp View 1 chunk +32 lines, -32 lines 0 comments Download
M src/core/SkBBoxRecord.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkFDot6.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkGeometry.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkLineClipper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkMaskGamma.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkMaskGamma.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBicubicImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurMask.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkColorMatrix.cpp View 3 chunks +16 lines, -16 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrPathUtils.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_win_dw.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/utils/SkCamera.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/utils/SkPathUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/win/SkDWriteGeometrySink.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M src/views/SkTouchGesture.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/AAClipTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/BlurTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClipCubicTest.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M tests/ClipperTest.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/DrawBitmapRectTest.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M tests/DrawTextTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ImageFilterTest.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M tests/LayerDrawLooperTest.cpp View 6 chunks +21 lines, -21 lines 0 comments Download
M tests/MathTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PaintTest.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M tests/ParsePathTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/PathMeasureTest.cpp View 5 chunks +16 lines, -16 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 chunk +13 lines, -13 lines 0 comments Download
M tests/PathTest.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M tests/PointTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/RoundRectTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/TileGridTest.cpp View 10 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
caryclark
7 years ago (2013-11-25 17:04:15 UTC) #1
reed1
have we grepped either Chrome or Android, for callers of this macro? Perhaps, if there ...
7 years ago (2013-11-25 18:09:36 UTC) #2
reed1
Derek, what is the frequency of callers for SkFloatToScalar?
7 years ago (2013-11-25 18:09:59 UTC) #3
vandebo (ex-Chrome)
On 2013/11/25 18:09:36, reed1 wrote: > have we grepped either Chrome or Android, for callers ...
7 years ago (2013-11-25 18:13:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/85463005/20102
7 years ago (2013-11-25 18:55:11 UTC) #5
commit-bot: I haz the power
7 years ago (2013-11-25 19:44:30 UTC) #6
Message was sent while issue was closed.
Change committed as 12385

Powered by Google App Engine
This is Rietveld 408576698