Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 845363004: <webview>, <appview> and <extensionoptions> can run in a detached state. (Closed)

Created:
5 years, 11 months ago by Fady Samuel
Modified:
5 years, 11 months ago
Reviewers:
paulmeyer
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

<webview>, <appview> and <extensionoptions> can run in a detached state. <webview>, <appview> and <extensionoptions> can now navigate on creation. This means that an initial navigation of these elements can begin even if the container is set to display:none. This sets the underpinnings for teleporting content across containers. TODO: contentWindow should become available prior to attachment. BUG=434226 TBR=lazyboy@chromium.org for guest_view OWNER (lazyboy@ is OOO) Committed: https://crrev.com/45802096c8354437dca4def794c03691f73e12b9 Cr-Commit-Position: refs/heads/master@{#312913}

Patch Set 1 #

Patch Set 2 : Can run in detached state #

Patch Set 3 : SurfaceView fix #

Total comments: 2

Patch Set 4 : Fixed spacing #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -133 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/extension_options.js View 6 chunks +10 lines, -32 lines 0 comments Download
M extensions/browser/guest_view/app_view/app_view_guest.h View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/guest_view/app_view/app_view_guest.cc View 1 2 3 4 2 chunks +12 lines, -15 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.h View 1 2 3 4 3 chunks +2 lines, -3 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.cc View 1 2 3 4 6 chunks +17 lines, -22 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 1 2 3 4 3 chunks +7 lines, -8 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 2 3 4 4 chunks +11 lines, -12 lines 0 comments Download
M extensions/renderer/resources/guest_view/app_view.js View 3 chunks +14 lines, -5 lines 0 comments Download
M extensions/renderer/resources/guest_view/guest_view.js View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/renderer/resources/guest_view/guest_view_container.js View 1 2 3 4 3 chunks +16 lines, -13 lines 0 comments Download
M extensions/renderer/resources/guest_view/surface_view.js View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view.js View 3 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Fady Samuel
5 years, 11 months ago (2015-01-13 19:38:58 UTC) #2
paulmeyer
lgtm + nit https://codereview.chromium.org/845363004/diff/40001/extensions/renderer/resources/guest_view/guest_view.js File extensions/renderer/resources/guest_view/guest_view.js (right): https://codereview.chromium.org/845363004/diff/40001/extensions/renderer/resources/guest_view/guest_view.js#newcode195 extensions/renderer/resources/guest_view/guest_view.js:195: this.handleCallback.bind(this, callback)); Spacing; it looks like ...
5 years, 11 months ago (2015-01-13 20:06:33 UTC) #3
Fady Samuel
Addressed CQ'ing https://codereview.chromium.org/845363004/diff/40001/extensions/renderer/resources/guest_view/guest_view.js File extensions/renderer/resources/guest_view/guest_view.js (right): https://codereview.chromium.org/845363004/diff/40001/extensions/renderer/resources/guest_view/guest_view.js#newcode195 extensions/renderer/resources/guest_view/guest_view.js:195: this.handleCallback.bind(this, callback)); On 2015/01/13 20:06:33, Paul Meyer ...
5 years, 11 months ago (2015-01-13 20:10:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845363004/60001
5 years, 11 months ago (2015-01-13 20:11:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/14437)
5 years, 11 months ago (2015-01-13 21:22:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845363004/80001
5 years, 11 months ago (2015-01-23 19:07:50 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 11 months ago (2015-01-23 20:11:10 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 20:13:15 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/45802096c8354437dca4def794c03691f73e12b9
Cr-Commit-Position: refs/heads/master@{#312913}

Powered by Google App Engine
This is Rietveld 408576698