Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.h

Issue 845363004: <webview>, <appview> and <extensionoptions> can run in a detached state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/extension_options/extension_options_guest.h
diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.h b/extensions/browser/guest_view/extension_options/extension_options_guest.h
index bc3d92928c3b3c4a90b678cf58b37f94840a3feb..b21aeda2ecd054359bd5dfcfc983afd2a3f63649 100644
--- a/extensions/browser/guest_view/extension_options/extension_options_guest.h
+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.h
@@ -27,9 +27,9 @@ class ExtensionOptionsGuest
int guest_instance_id);
// GuestViewBase implementation.
+ bool CanRunInDetachedState() const override;
void CreateWebContents(const base::DictionaryValue& create_params,
const WebContentsCreatedCallback& callback) override;
- void DidAttachToEmbedder() override;
void DidInitialize(const base::DictionaryValue& create_params) override;
void DidStopLoading() override;
const char* GetAPINamespace() const override;
@@ -37,8 +37,8 @@ class ExtensionOptionsGuest
void GuestSizeChangedDueToAutoSize(const gfx::Size& old_size,
const gfx::Size& new_size) override;
bool IsAutoSizeSupported() const override;
- void OnPreferredSizeChanged(const gfx::Size& pref_size) override;
bool IsPreferredSizeModeEnabled() const override;
+ void OnPreferredSizeChanged(const gfx::Size& pref_size) override;
// ExtensionFunctionDispatcher::Delegate implementation.
content::WebContents* GetAssociatedWebContents() const override;
@@ -76,7 +76,6 @@ class ExtensionOptionsGuest
scoped_ptr<extensions::ExtensionOptionsGuestDelegate>
extension_options_guest_delegate_;
GURL options_page_;
- bool has_navigated_;
DISALLOW_COPY_AND_ASSIGN(ExtensionOptionsGuest);
};

Powered by Google App Engine
This is Rietveld 408576698