extensions/browser/guest_view/app_view/app_view_guest.h - Issue 845363004: <webview>, <appview> and <extensionoptions> can run in a detached state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/app_view/app_view_guest.h

Issue 845363004: <webview>, <appview> and <extensionoptions> can run in a detached state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/extension_options.js ('k') | extensions/browser/guest_view/app_view/app_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/app_view/app_view_guest.h

diff --git a/extensions/browser/guest_view/app_view/app_view_guest.h b/extensions/browser/guest_view/app_view/app_view_guest.h

index 020ed734a40ed69dcc9c8ca53e28d6400121afeb..fa8ce8ea9cfc4b4492dd847e41fc77dd5fd785c5 100644

--- a/extensions/browser/guest_view/app_view/app_view_guest.h

+++ b/extensions/browser/guest_view/app_view/app_view_guest.h

@@ -52,12 +52,12 @@ class AppViewGuest : public GuestView<AppViewGuest>,

content::MediaStreamType type) override;

// GuestViewBase implementation.

- const char* GetAPINamespace() const override;

- int GetTaskPrefix() const override;

+ bool CanRunInDetachedState() const override;

void CreateWebContents(const base::DictionaryValue& create_params,

const WebContentsCreatedCallback& callback) override;

- void DidAttachToEmbedder() override;

void DidInitialize(const base::DictionaryValue& create_params) override;

+ const char* GetAPINamespace() const override;

+ int GetTaskPrefix() const override;

// Sets the AppDelegate for this guest.

void SetAppDelegateForTest(AppDelegate* delegate);