Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 845363004: <webview>, <appview> and <extensionoptions> can run in a detached state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.h
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h
index 3c15ba394c575ae7bd81b211d2a36063e8f3a8d3..63a1f4892f233f25a9b6a07bc53e1d487353ad36 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.h
+++ b/extensions/browser/guest_view/web_view/web_view_guest.h
@@ -90,14 +90,15 @@ class WebViewGuest : public GuestView<WebViewGuest>,
std::string* error);
// GuestViewBase implementation.
- const char* GetAPINamespace() const override;
- int GetTaskPrefix() const override;
+ bool CanRunInDetachedState() const override;
void CreateWebContents(const base::DictionaryValue& create_params,
const WebContentsCreatedCallback& callback) override;
void DidAttachToEmbedder() override;
void DidInitialize(const base::DictionaryValue& create_params) override;
void DidStopLoading() override;
void EmbedderWillBeDestroyed() override;
+ const char* GetAPINamespace() const override;
+ int GetTaskPrefix() const override;
void GuestDestroyed() override;
void GuestReady() override;
void GuestSizeChangedDueToAutoSize(const gfx::Size& old_size,
@@ -132,6 +133,10 @@ class WebViewGuest : public GuestView<WebViewGuest>,
content::WebContents* source,
const content::MediaStreamRequest& request,
const content::MediaResponseCallback& callback) override;
+ void RequestPointerLockPermission(
+ bool user_gesture,
+ bool last_unlocked_by_target,
+ const base::Callback<void(bool)>& callback) override;
bool CheckMediaAccessPermission(content::WebContents* source,
const GURL& security_origin,
content::MediaStreamType type) override;
@@ -160,12 +165,6 @@ class WebViewGuest : public GuestView<WebViewGuest>,
const GURL& target_url,
content::WebContents* new_contents) override;
- // BrowserPluginGuestDelegate implementation.
- bool CanRunInDetachedState() const override;
- void RequestPointerLockPermission(
- bool user_gesture,
- bool last_unlocked_by_target,
- const base::Callback<void(bool)>& callback) override;
// NotificationObserver implementation.
void Observe(int type,
const content::NotificationSource& source,

Powered by Google App Engine
This is Rietveld 408576698