Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 845363004: <webview>, <appview> and <extensionoptions> can run in a detached state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc
index 7176e10185b83dcd75821dfd93743c0c330daa64..da0b11a195cdc7411cc95558ca98274375f6d308 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc
@@ -216,12 +216,8 @@ int WebViewGuest::GetViewInstanceId(WebContents* contents) {
return guest->view_instance_id();
}
-const char* WebViewGuest::GetAPINamespace() const {
- return webview::kAPINamespace;
-}
-
-int WebViewGuest::GetTaskPrefix() const {
- return IDS_EXTENSION_TASK_MANAGER_WEBVIEW_TAG_PREFIX;
+bool WebViewGuest::CanRunInDetachedState() const {
+ return true;
}
void WebViewGuest::CreateWebContents(
@@ -303,8 +299,7 @@ void WebViewGuest::DidInitialize(const base::DictionaryValue& create_params) {
// requests.
PushWebViewStateToIOThread();
- // TODO(fsamuel): Once <webview> can run in a detached state, call
- // ApplyAttributes here.
+ ApplyAttributes(create_params);
}
void WebViewGuest::AttachWebViewHelpers(WebContents* contents) {
@@ -338,6 +333,14 @@ void WebViewGuest::EmbedderWillBeDestroyed() {
view_instance_id()));
}
+const char* WebViewGuest::GetAPINamespace() const {
+ return webview::kAPINamespace;
+}
+
+int WebViewGuest::GetTaskPrefix() const {
+ return IDS_EXTENSION_TASK_MANAGER_WEBVIEW_TAG_PREFIX;
+}
+
void WebViewGuest::GuestDestroyed() {
// Clean up custom context menu items for this guest.
if (web_view_guest_delegate_)
@@ -481,10 +484,6 @@ void WebViewGuest::OnFrameNameChanged(bool is_top_level,
ReportFrameNameChange(name);
}
-bool WebViewGuest::CanRunInDetachedState() const {
- return false;
-}
-
void WebViewGuest::CreateNewGuestWebViewWindow(
const content::OpenURLParams& params) {
GuestViewManager* guest_manager =
« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_guest.h ('k') | extensions/renderer/resources/guest_view/app_view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698