Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: extensions/renderer/resources/guest_view/surface_view.js

Issue 845363004: <webview>, <appview> and <extensionoptions> can run in a detached state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/guest_view/surface_view.js
diff --git a/extensions/renderer/resources/guest_view/surface_view.js b/extensions/renderer/resources/guest_view/surface_view.js
index 421aeaae94170febacc8afb5b4b80b4083132163..137525c4392f1fc0f4142bd7290a9e4c9c401036 100644
--- a/extensions/renderer/resources/guest_view/surface_view.js
+++ b/extensions/renderer/resources/guest_view/surface_view.js
@@ -25,6 +25,10 @@ SurfaceViewImpl.setupElement = function(proto) {
GuestViewContainer.forwardApiMethods(proto, apiMethods);
}
+SurfaceViewImpl.prototype.buildContainerParams = function() {
+ return { 'url': this.url };
+};
+
SurfaceViewImpl.prototype.connect = function(url, callback) {
if (!this.elementAttached) {
if (callback) {
@@ -33,13 +37,11 @@ SurfaceViewImpl.prototype.connect = function(url, callback) {
return;
}
- this.guest.destroy();
+ this.url = url;
- var createParams = {
- 'url': url
- };
+ this.guest.destroy();
- this.guest.create(createParams, function() {
+ this.guest.create(this.buildParams(), function() {
this.attachWindow();
if (callback) {
callback(true);
« no previous file with comments | « extensions/renderer/resources/guest_view/guest_view_container.js ('k') | extensions/renderer/resources/guest_view/web_view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698