Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 841773006: Extract WebGraphicsContext3DInProcessCommandBufferImpl from webkit/. (Closed)

Created:
5 years, 11 months ago by tfarina
Modified:
5 years, 11 months ago
Reviewers:
jamesr, boliu, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Ian Vollick, cc-bugs_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, android-webview-reviews_chromium.org, Avi (use Gerrit), darin (slow to review), jochen (gone - plz use gerrit), pilgrim_google
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract WebGraphicsContext3DInProcessCommandBufferImpl from webkit/. This moves it into gpu/blink/ along side WebGraphicsContext3DImpl, consolidating more this code as we are in the process of removing webkit/ glue directory altogether. This is one more step on this way. BUG=338338 TEST=compositor_unittests, gpu_unittests, content_unittests R=jamesr@chromium.org,piman@chromium.org TBR=boliu@chromium.org Committed: https://crrev.com/70da38b26b718679d02e579c8b0ea89fd38de06a Cr-Commit-Position: refs/heads/master@{#310694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -347 lines) Patch
M android_webview/browser/hardware_renderer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M content/browser/gpu/gpu_ipc_browsertests.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/common/gpu/client/gl_helper_benchmark.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/gpu/client/gl_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_in_process_context_tests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/android/synchronous_compositor_factory.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/blink/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/blink/gpu_blink.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.h View 3 chunks +9 lines, -14 lines 0 comments Download
A + gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ui/compositor/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M webkit/common/gpu/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.h View 4 chunks +6 lines, -4 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.cc View 2 chunks +3 lines, -2 lines 0 comments Download
D webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 chunk +0 lines, -110 lines 0 comments Download
D webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +0 lines, -180 lines 0 comments Download
M webkit/common/gpu/webkit_gpu.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
tfarina
PTAL
5 years, 11 months ago (2015-01-08 13:54:28 UTC) #1
jamesr
lgtm
5 years, 11 months ago (2015-01-08 18:41:49 UTC) #2
piman
lgtm
5 years, 11 months ago (2015-01-08 19:05:16 UTC) #3
tfarina
TBRing Boliu for androd_webview (all mechanic changes).
5 years, 11 months ago (2015-01-09 01:25:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841773006/1
5 years, 11 months ago (2015-01-09 01:27:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 03:17:02 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/70da38b26b718679d02e579c8b0ea89fd38de06a Cr-Commit-Position: refs/heads/master@{#310694}
5 years, 11 months ago (2015-01-09 03:18:02 UTC) #9
boliu
5 years, 11 months ago (2015-01-12 02:46:59 UTC) #10
Message was sent while issue was closed. 
On 2015/01/09 01:25:56, tfarina wrote:
> TBRing Boliu for androd_webview (all mechanic changes).

lgtm

Powered by Google App Engine
This is Rietveld 408576698