Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 840813009: Enable strict-virtual-specifiers for iOS builds. (Closed)

Created:
5 years, 11 months ago by droger
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable strict-virtual-specifiers for iOS builds. This CL cleans up the remaining errors and enables the compile time check in common.gypi. BUG=417463 Committed: https://crrev.com/b4a495753c1c291ca0209c2765e6562a723c5959 Cr-Commit-Position: refs/heads/master@{#312269}

Patch Set 1 #

Patch Set 2 : Fix compile errors #

Patch Set 3 : more fixes #

Patch Set 4 : #

Total comments: 5

Patch Set 5 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -200 lines) Patch
M base/message_loop/message_pump_io_ios.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_io_ios_unittest.cc View 1 2 3 6 chunks +13 lines, -19 lines 0 comments Download
M base/message_loop/message_pump_mac.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/variations/variations_request_scheduler_mobile.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_mobile.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M components/enhanced_bookmarks/image_store_util_ios.mm View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M components/policy/core/browser/browser_policy_connector_ios.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/core/browser/browser_policy_connector_ios.mm View 1 2 3 1 chunk +4 lines, -6 lines 0 comments Download
M components/policy/core/common/policy_loader_ios.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M components/policy/core/common/policy_loader_ios_unittest.mm View 1 2 3 1 chunk +13 lines, -14 lines 0 comments Download
M components/sessions/ios/ios_serialized_navigation_driver.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/test_signin_client.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/signin/ios/browser/oauth2_token_service_observer_bridge.h View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M components/signin/ios/browser/profile_oauth2_token_service_ios.h View 1 2 3 3 chunks +21 lines, -23 lines 0 comments Download
M components/signin/ios/browser/profile_oauth2_token_service_ios.mm View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M content/public/browser/resource_context.h View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M ios/chrome/browser/suggestions/suggestions_service_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ios/public/test/fake_profile_oauth2_token_service_ios_provider.h View 1 2 1 chunk +9 lines, -9 lines 0 comments Download
M ios/public/test/test_chrome_browser_provider.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/web/navigation/navigation_item_impl.h View 1 2 3 1 chunk +21 lines, -21 lines 0 comments Download
M ios/web/navigation/navigation_item_impl_unittest.mm View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M ios/web/public/test/test_web_state.h View 1 2 3 1 chunk +15 lines, -16 lines 0 comments Download
M ios/web/public/web_state/web_state.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/blockfile/file_ios.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M net/proxy/proxy_config_service_ios.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image.cc View 1 2 3 1 chunk +4 lines, -10 lines 0 comments Download
M ui/gfx/image/image_ios_unittest.mm View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/platform_font_ios.h View 1 2 3 4 1 chunk +12 lines, -12 lines 0 comments Download
M ui/gfx/screen_ios.mm View 1 2 3 4 3 chunks +11 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
droger
5 years, 11 months ago (2015-01-20 11:59:52 UTC) #2
jif-google
lgtm
5 years, 11 months ago (2015-01-20 12:13:35 UTC) #4
droger
+thakis as OWNER of buid/common.gypi, base, chrome and ui + jochen as OWNER of components ...
5 years, 11 months ago (2015-01-20 12:51:33 UTC) #6
Nico
BUG=417463
5 years, 11 months ago (2015-01-20 15:43:40 UTC) #7
Nico
lgtm with BUG= line in cl description. There are a bunch of unrelated copyright comment ...
5 years, 11 months ago (2015-01-20 15:48:27 UTC) #8
droger
Thanks for the review. Everything done. https://codereview.chromium.org/840813009/diff/60001/ui/gfx/screen_ios.mm File ui/gfx/screen_ios.mm (right): https://codereview.chromium.org/840813009/diff/60001/ui/gfx/screen_ios.mm#newcode15 ui/gfx/screen_ios.mm:15: ~ScreenIos() override {} ...
5 years, 11 months ago (2015-01-20 16:13:06 UTC) #9
mef
net/ lgtm
5 years, 11 months ago (2015-01-20 17:11:50 UTC) #10
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-20 19:20:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840813009/80001
5 years, 11 months ago (2015-01-20 20:31:43 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 11 months ago (2015-01-20 20:56:15 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 20:57:18 UTC) #15
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/b4a495753c1c291ca0209c2765e6562a723c5959
Cr-Commit-Position: refs/heads/master@{#312269}

Powered by Google App Engine
This is Rietveld 408576698